chore: clean-up - #14383
Merged
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Propagates fix from 600a127 ("docs: fix descriptions") to sibling doc surfaces which use the unhyphenated compound adjective "floating point" (REPL help, TypeScript declarations, READMEs, JSDoc, C doc comments, and package descriptions) in `blas/base`, `math/base/special`, `array`, and `types`. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016B1i21KTYKBJ3n5E3mSFp3
Propagates fix from 6a94f93 ("chore: fix JavaScript lint errors") to sibling packages with the same `new Array()` constructor usage, which violates the `stdlib/no-new-array` ESLint rule. Replaces preallocation plus indexed fill with an array literal and `push`, preserving element order and semantics. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016B1i21KTYKBJ3n5E3mSFp3
Planeshifter
force-pushed
the
claude/ecstatic-heisenberg-bz8lov
branch
from
August 18, 2026 13:44
56369b2 to
37b7707
Compare
floating-point and no-new-array fixesfloating-point and no-new-array fixes
Planeshifter
marked this pull request as ready for review
August 18, 2026 16:25
kgryte
approved these changes
Aug 19, 2026
floating-point and no-new-array fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request propagates fixes merged to
developbetween 2026-08-17 and 2026-08-18 (0acfa70d8..600a127f0) to sibling packages with the same underlying defects.floating point→floating-point(source: 600a127)This PR extends the fix from 600a127 to the sibling doc surfaces that commit missed. Same defect, same treatment: unhyphenated
floating pointused attributively becomesfloating-point— 33 lines, 17 files, prose only.blas/base/wasm/dswap,blas/base/wasm/sswap—docs/repl.txt,docs/types/index.d.tsblas/base/caxpy,blas/base/zaxpy—docs/repl.txtmath/base/special/ahavercosf— README, JSDoc,package.jsondescriptionmath/base/special/floor2f— header, JSDoc, C sourcearray/base/logspace,array/logspace— READMEstypes—index.d.tsOccurrences inside FDLIBM-ported algorithm notes and printf conversion-specifier terminology are untouched — those are quoted/attributed source text, not stdlib prose.
stdlib/no-new-arraylint errors (source: 6a94f93)Fixes the same
stdlib/no-new-arrayviolation pattern in the remaining single-site packages, following commit 6a94f93 (#14286):new Array( n )preallocation plus indexed fill replaced with an array literal andpush. Loop bounds that referenced the preallocated array's length are rewritten to invariant expressions; element order and semantics are unchanged. Applies to:utils/papplyutils/papply-rightutils/async/do-untilutils/open-urlutils/compose,utils/function-sequence, andutils/async/composeare excluded: each has a secondnew Arraysite of a different shape, and fixing only the matching site would leave the rule still failing there. Those require a separate PR.Related Issues
No related issues.
Questions
No.
Other
Two additional sites were fixed and subsequently excluded after CI surfaced pre-existing failures unrelated to the changes themselves:
string/format(README hyphenation): the README has four pre-existing doctest mismatches in unrelated example blocks (lines 93–125, 162–178, 213–230), so any edit to the file fails the changed-examples check. The hyphenation fix should land together with corrections to those examples.utils/merge(stdlib/no-new-arrayfix): touchingutils/mergeruns the test suites of its_tools/github/*dependents, and_tools/github/rank-followers/test/test.cli.jshas pre-existing failures — the tests assertopts.format/opts.delimiter, whichbin/clinever sets (the format fixture also passes--format=jsonwhile the test expects'csv'). Theutils/mergefix should land once those dependent tests are corrected.Validation performed before applying changes:
utils/push).string/formatREADME example strings,utils/compose,utils/function-sequence,utils/async/compose(secondnew Arraysite of a different shape),utils/reverse-arguments(reverse-order fill),utils/pluck/utils/deep-pluck(conditional aliasing).node --check; patchedutilsfunctions were smoke-tested for behavior preservation (papply,papply-right,async/do-until).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated fix-propagation routine: recent fixes on
developwere pattern-matched against sibling packages, and each candidate site was validated by independent review passes before the equivalent fix was applied.🤖 Generated with Claude Code
https://claude.ai/code/session_016B1i21KTYKBJ3n5E3mSFp3