Skip to content

chore: clean-up - #14383

Merged
kgryte merged 2 commits into
developfrom
claude/ecstatic-heisenberg-bz8lov
Aug 19, 2026
Merged

chore: clean-up#14383
kgryte merged 2 commits into
developfrom
claude/ecstatic-heisenberg-bz8lov

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 18, 2026

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request propagates fixes merged to develop between 2026-08-17 and 2026-08-18 (0acfa70d8..600a127f0) to sibling packages with the same underlying defects.

floating pointfloating-point (source: 600a127)

This PR extends the fix from 600a127 to the sibling doc surfaces that commit missed. Same defect, same treatment: unhyphenated floating point used attributively becomes floating-point — 33 lines, 17 files, prose only.

  • blas/base/wasm/dswap, blas/base/wasm/sswapdocs/repl.txt, docs/types/index.d.ts
  • blas/base/caxpy, blas/base/zaxpydocs/repl.txt
  • math/base/special/ahavercosf — README, JSDoc, package.json description
  • math/base/special/floor2f — header, JSDoc, C source
  • array/base/logspace, array/logspace — READMEs
  • typesindex.d.ts

Occurrences inside FDLIBM-ported algorithm notes and printf conversion-specifier terminology are untouched — those are quoted/attributed source text, not stdlib prose.

stdlib/no-new-array lint errors (source: 6a94f93)

Fixes the same stdlib/no-new-array violation pattern in the remaining single-site packages, following commit 6a94f93 (#14286): new Array( n ) preallocation plus indexed fill replaced with an array literal and push. Loop bounds that referenced the preallocated array's length are rewritten to invariant expressions; element order and semantics are unchanged. Applies to:

  • utils/papply
  • utils/papply-right
  • utils/async/do-until
  • utils/open-url

utils/compose, utils/function-sequence, and utils/async/compose are excluded: each has a second new Array site of a different shape, and fixing only the matching site would leave the rule still failing there. Those require a separate PR.

Related Issues

Does this pull request have any related issues?

No related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Two additional sites were fixed and subsequently excluded after CI surfaced pre-existing failures unrelated to the changes themselves:

  • string/format (README hyphenation): the README has four pre-existing doctest mismatches in unrelated example blocks (lines 93–125, 162–178, 213–230), so any edit to the file fails the changed-examples check. The hyphenation fix should land together with corrections to those examples.
  • utils/merge (stdlib/no-new-array fix): touching utils/merge runs the test suites of its _tools/github/* dependents, and _tools/github/rank-followers/test/test.cli.js has pre-existing failures — the tests assert opts.format/opts.delimiter, which bin/cli never sets (the format fixture also passes --format=json while the test expects 'csv'). The utils/merge fix should land once those dependent tests are corrected.

Validation performed before applying changes:

  • Candidate sites enumerated via pattern search over the affected namespaces; occurrences in FDLIBM-ported comments, printf terminology, noun-phrase usage ("in floating point"), bot-regenerated namespace TOCs, and dataset contents were excluded.
  • Two independent validation passes confirmed each site in full file context; an adaptation pass produced per-site patches; a style-consistency pass verified conformance with surrounding package conventions (e.g., the uncached-loop-bound idiom in utils/push).
  • Sites flagged as requiring human judgment were dropped: string/format README example strings, utils/compose, utils/function-sequence, utils/async/compose (second new Array site of a different shape), utils/reverse-arguments (reverse-order fill), utils/pluck/utils/deep-pluck (conditional aliasing).
  • All modified JavaScript passes node --check; patched utils functions were smoke-tested for behavior preservation (papply, papply-right, async/do-until).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated fix-propagation routine: recent fixes on develop were pattern-matched against sibling packages, and each candidate site was validated by independent review passes before the equivalent fix was applied.

🤖 Generated with Claude Code

https://claude.ai/code/session_016B1i21KTYKBJ3n5E3mSFp3

@stdlib-bot

stdlib-bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/logspace $\\color{green}105/105$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}105/105$
$\\color{green}+100.00\\%$
array/logspace $\\color{green}105/105$
$\\color{green}+0.00\\%$
$\\color{green}13/13$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}105/105$
$\\color{green}+0.00\\%$
blas/base/caxpy $\\color{green}368/368$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}368/368$
$\\color{green}+0.00\\%$
blas/base/wasm/dswap $\\color{green}661/661$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}6/6$
$\\color{green}+0.00\\%$
$\\color{green}661/661$
$\\color{green}+0.00\\%$
blas/base/wasm/sswap $\\color{green}661/661$
$\\color{green}+0.00\\%$
$\\color{green}17/17$
$\\color{green}+0.00\\%$
$\\color{green}6/6$
$\\color{green}+0.00\\%$
$\\color{green}661/661$
$\\color{green}+0.00\\%$
blas/base/zaxpy $\\color{green}417/417$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}417/417$
$\\color{green}+0.00\\%$
math/base/special/ahavercosf $\\color{green}171/171$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}171/171$
$\\color{green}+0.00\\%$
math/base/special/floor2f $\\color{green}202/202$
$\\color{green}+0.00\\%$
$\\color{green}19/19$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}202/202$
$\\color{green}+0.00\\%$
types $\\color{green}107/107$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}0/0$
$\\color{green}+0.00\\%$
$\\color{green}107/107$
$\\color{green}+0.00\\%$
utils/async/do-until $\\color{green}185/185$
$\\color{green}+0.00\\%$
$\\color{green}22/22$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}185/185$
$\\color{green}+0.00\\%$
utils/open-url $\\color{green}185/185$
$\\color{green}+0.00\\%$
$\\color{green}15/15$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}185/185$
$\\color{green}+0.00\\%$
utils/papply $\\color{green}126/126$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}126/126$
$\\color{green}+0.00\\%$
utils/papply-right $\\color{green}140/140$
$\\color{green}+0.00\\%$
$\\color{green}11/11$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}140/140$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

claude added 2 commits August 18, 2026 13:43
Propagates fix from 600a127 ("docs: fix descriptions") to sibling
doc surfaces which use the unhyphenated compound adjective "floating
point" (REPL help, TypeScript declarations, READMEs, JSDoc, C doc
comments, and package descriptions) in `blas/base`, `math/base/special`,
`array`, and `types`.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016B1i21KTYKBJ3n5E3mSFp3
Propagates fix from 6a94f93 ("chore: fix JavaScript lint errors") to
sibling packages with the same `new Array()` constructor usage, which
violates the `stdlib/no-new-array` ESLint rule. Replaces preallocation
plus indexed fill with an array literal and `push`, preserving element
order and semantics.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016B1i21KTYKBJ3n5E3mSFp3
@Planeshifter
Planeshifter force-pushed the claude/ecstatic-heisenberg-bz8lov branch from 56369b2 to 37b7707 Compare August 18, 2026 13:44
@Planeshifter Planeshifter changed the title docs: propagate floating-point and no-new-array fixes chore: propagate floating-point and no-new-array fixes Aug 18, 2026
@Planeshifter
Planeshifter requested a review from kgryte August 18, 2026 16:25
@Planeshifter
Planeshifter marked this pull request as ready for review August 18, 2026 16:25
@Planeshifter
Planeshifter requested a review from a team August 18, 2026 16:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 18, 2026
@kgryte kgryte changed the title chore: propagate floating-point and no-new-array fixes chore: clean-up Aug 19, 2026
@kgryte
kgryte merged commit 72b23ea into develop Aug 19, 2026
38 checks passed
@kgryte
kgryte deleted the claude/ecstatic-heisenberg-bz8lov branch August 19, 2026 07:16
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants