fix: correct variable ordering in cauchy CDF implementation#5542
Closed
ChaitraTM wants to merge 3 commits intostdlib-js:developfrom
Closed
fix: correct variable ordering in cauchy CDF implementation#5542ChaitraTM wants to merge 3 commits intostdlib-js:developfrom
ChaitraTM wants to merge 3 commits intostdlib-js:developfrom
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Mar 1, 2025
| } | ||
|
|
||
| int main( void ) { | ||
| //correct order based on the length |
Member
There was a problem hiding this comment.
Suggested change
| //correct order based on the length |
kgryte
reviewed
Mar 1, 2025
| // VARIABLES // | ||
|
|
||
| var logcdf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||
| //corected variable name |
Member
There was a problem hiding this comment.
Suggested change
| //corected variable name |
kgryte
reviewed
Mar 1, 2025
lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.native.js
Show resolved
Hide resolved
kgryte
reviewed
Mar 1, 2025
lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/examples/c/example.c
Outdated
Show resolved
Hide resolved
Author
|
I ain't getting what's the conflict that must be resolved |
Member
|
@ChaitraTM It looks like you've corrupted this PR. Your most recent commit made hundreds of changes which we do not want. I'll need to close this PR, as the changes won't be accepted as is. I suggest trying again in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5431 .
Description
This pull request:
example.cbenchmark.native.jscdf.hRelated Issues
This pull request:
8fa3827) #5431Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers