ci: skip macOS shards for docs-only changes - #1654
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 1:07 PM ET / 17:07 UTC. Summary Reproducibility: not applicable. this is a CI workflow optimization rather than a bug report. The relevant behavior is evidenced by source inspection, gate fixtures, and a hosted docs-only Actions proof run. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the guarded skip only after exact-head CI completes and maintainers accept the docs-only macOS skip policy with the strict name-status gate and Do we have a high-confidence way to reproduce the issue? Not applicable; this is a CI workflow optimization rather than a bug report. The relevant behavior is evidenced by source inspection, gate fixtures, and a hosted docs-only Actions proof run. Is this the best way to solve the issue? Yes, with maintainer policy acceptance: the current design is narrow and fail-closed around non-Markdown changes, malformed input, renames, empty diffs, and the macOS-only AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 20a4357ad544. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73a96c37ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@clawsweeper re-review Added GitHub Actions proof in the PR body: fork proof PR Yuxin-Qiao#3 changes only docs/ci-path-gate-proof.md against this branch, and run 27831467301 shows changes=success, swift-test-macos=skipped, lint-build-test=success, lint=success. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review I addressed both P2 findings in
Validation added to the PR body includes focused name-status samples for docs-only, source, script/workflow, app-localization, empty-list, source-to-docs rename, docs-to-docs rename, plus docs-link and lint checks. New docs-only proof run: https://github.com/Yuxin-Qiao/CodexBar/actions/runs/27832419332 Key proof results:
|
|
🦞🧹 I asked ClawSweeper to review this item again. |
cc4570d to
0adb1f7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0adb1f7d1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0adb1f7 to
92177b4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92177b4469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Landed as Exact head Thanks @Yuxin-Qiao! |
Summary
changesjob that skips macOS Swift test shards only for Markdown-only changesgit diff --name-status, including both rename/copy paths, and fail closed on malformed inputtrue:successorfalse:skippedgate/result pairsSafety
AGENTS.mdanddocs/configuration.mdalways require macOS tests because macOS-only tests validate their safety/provider contractsR0-R100/C0-C100status plus both paths; malformed or unterminated rows fail without emitting a skip outputVerification
Exact head:
8b8e87d1711a124fede8125bf282dc38cb46d5c3./Scripts/test_ci_path_gate.sh: passed using actualGITHUB_OUTPUTAGENTS.mdand configuration-doc fixtures cover direct modification plus rename into and out of each exact pathnode Scripts/check-documentation-links.mjs: 114 local links passedmake check: passed; SwiftFormat clean and SwiftLint reported zero violationsmake test: all 41 groups passed on the exact rebased headdocs/*, incomplete rename, malformed score, unterminated-row, configuration-doc, and agent-safety gaps; final full-branch review clean (0.86)Prior GitHub Actions proof
The contributor's docs-only proof run demonstrated
changes: success, Linux lint success, macOS shards skipped, aggregate success, and both Linux builds success: https://github.com/Yuxin-Qiao/CodexBar/actions/runs/27832419332