Skip to content

ci: add workflow summary observability - #1718

Merged
steipete merged 1 commit into
steipete:mainfrom
Yuxin-Qiao:codex/ci-summary-observability
Jun 23, 2026
Merged

ci: add workflow summary observability#1718
steipete merged 1 commit into
steipete:mainfrom
Yuxin-Qiao:codex/ci-summary-observability

Conversation

@Yuxin-Qiao

@Yuxin-Qiao Yuxin-Qiao commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add GitHub Actions step summaries for the macOS test gate, macOS shards, Linux CLI builds, and the aggregate CI gate
  • expose the macOS gate reason and changed path count as job outputs for downstream summaries
  • extend focused path-gate tests to verify the new observability outputs

No behavior change

  • does not change CI pass/fail rules
  • does not change macOS sharding, runner labels, timeouts, or skip policy
  • does not add GitHub API calls or queue-time polling

Real GitHub Actions proof

Exact-head workflow run completed successfully for 924046af311d24fa13e1b6c88e2764e0d1782207:

This verifies the added summary steps run in the real PR workflow, not only in local shell checks.

Validation

  • bash -n Scripts/ci_macos_test_gate.sh
  • bash -n Scripts/test_ci_path_gate.sh
  • ./Scripts/test_ci_path_gate.sh
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml")'\n- git diff --check

@clawsweeper

clawsweeper Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge. Reviewed June 22, 2026, 10:53 PM ET / 02:53 UTC.

Summary
The PR adds GitHub Actions job summaries and two macOS test-gate outputs across the CI workflow, gate script, and focused path-gate tests.

Reproducibility: not applicable. this is a CI observability PR, not a reported product bug. The relevant checks are diff/source review plus exact-head workflow behavior.

Review metrics: 3 noteworthy metrics.

  • Files changed: 3 files, 113 additions, 0 deletions. The diff is small but touches CI workflow automation and its shell gate tests.
  • Workflow summary steps: 4 added summary steps. Each new summary step runs in CI and can affect job completion if the shell block fails.
  • Gate outputs: 2 added outputs. Downstream aggregate summaries now depend on new macOS gate outputs.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add redacted proof that the GitHub Actions summaries render on the PR workflow after the change.
  • Let exact-head CI finish so all macOS, Linux, and aggregate summary steps have run.

Proof guidance:

  • [P1] Needs real behavior proof before merge: The PR body lists validation commands but does not include after-fix rendered workflow summary proof; the contributor should add a redacted screenshot, copied live output, log, or linked artifact and update the PR body to trigger review.

Risk before merge

  • [P1] This PR changes CI automation by adding always-run shell summary steps; a summary-step runtime problem would affect CI even though the intended change is observability-only.
  • [P1] The PR body lists local validation commands, but no rendered GitHub Actions summary proof is attached yet, and the observed exact-head workflow was still incomplete during review.

Maintainer options:

  1. Require rendered summary proof (recommended)
    Ask the contributor to add a screenshot, copied live output, or linked artifact showing the after-fix GitHub Actions summaries from the PR workflow before merge.
  2. Accept CI-only validation
    Maintainers could choose to merge once exact-head CI is green, accepting that summary usefulness was not visually verified in the review evidence.

Next step before merge

  • [P1] A maintainer should wait for contributor-supplied real workflow-summary proof and completed exact-head CI; there is no narrow repair task for ClawSweeper to perform.

Security
Cleared: The diff changes CI summary shell blocks and outputs but adds no new secrets, permissions, third-party actions, dependency sources, or credential handling.

Review details

Best possible solution:

Land the narrow CI-summary implementation after exact-head CI completes and the contributor adds redacted proof showing the rendered workflow summaries for the changed jobs.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a CI observability PR, not a reported product bug. The relevant checks are diff/source review plus exact-head workflow behavior.

Is this the best way to solve the issue?

Unclear until proof is added: the implementation is narrow and consistent with the existing path-gate scripts, but the rendered GitHub Actions summaries still need real-run evidence.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against ef8007fc16ce.

Label changes

Label changes:

  • add P3: This is low-risk CI observability and test coverage work with no product runtime behavior change.
  • add merge-risk: 🚨 automation: The PR modifies GitHub Actions automation and adds always-run shell summary steps whose rendered behavior needs exact-head proof.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body lists validation commands but does not include after-fix rendered workflow summary proof; the contributor should add a redacted screenshot, copied live output, log, or linked artifact and update the PR body to trigger review.

Label justifications:

  • P3: This is low-risk CI observability and test coverage work with no product runtime behavior change.
  • merge-risk: 🚨 automation: The PR modifies GitHub Actions automation and adds always-run shell summary steps whose rendered behavior needs exact-head proof.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body lists validation commands but does not include after-fix rendered workflow summary proof; the contributor should add a redacted screenshot, copied live output, log, or linked artifact and update the PR body to trigger review.
Evidence reviewed

What I checked:

  • Current main does not already have summaries: Current main's CI workflow exposes only the macOS test gate output and has no GITHUB_STEP_SUMMARY usage, so this PR is not obsolete on main. (.github/workflows/ci.yml:19, ef8007fc16ce)
  • Proposed CI changes: The PR adds four always-run workflow summary steps and adds macos-tests-reason plus changed-path-count outputs from the macOS path gate. (.github/workflows/ci.yml:18, 924046af311d)
  • Focused test coverage added: The PR extends the path-gate shell test to require a non-empty macos-tests-reason output, a numeric changed-path-count output, and the docs/site skip reason for false gates. (Scripts/test_ci_path_gate.sh:21, 924046af311d)
  • Real behavior proof gap: The PR body lists local validation commands, and the observed PR workflow had the changes summary step completed while macOS/Linux/aggregate summary steps were still pending; no rendered summary screenshot, log, or completed run artifact was provided. (924046af311d)
  • No canonical replacement found: Searches for workflow summary observability and GITHUB_STEP_SUMMARY did not find another active issue or PR that owns this exact remaining work.
  • CI ownership history: The macOS path-gate workflow and scripts were introduced by merged PR ci: skip macOS shards for docs-only changes #1654, with later CI workflow work in ci: cache Linux Swift toolchains #1670. (Scripts/ci_macos_test_gate.sh:1, 669d1e9b08ee)

Likely related people:

  • Yuxin-Qiao: Authored the merged macOS path-gate work in ci: skip macOS shards for docs-only changes #1654 and the later Linux Swift toolchain cache CI change in ci: cache Linux Swift toolchains #1670, both touching the same workflow surface. (role: recent CI feature contributor; confidence: high; commits: 669d1e9b08ee, 802d7784510e; files: .github/workflows/ci.yml, Scripts/ci_macos_test_gate.sh, Scripts/test_ci_path_gate.sh)
  • steipete: Merged the related path-gate and Linux CI PRs and appears in recent CI history for the same workflow and scripts. (role: recent CI reviewer and merger; confidence: high; commits: 669d1e9b08ee, 06770308831e, f380287041b8; files: .github/workflows/ci.yml, Scripts/ci_macos_test_gate.sh, Scripts/test_ci_path_gate.sh)
  • Ratul Sarna: Appears in earlier macOS CI workflow history for runner and test execution changes, making them a lower-confidence adjacent routing candidate if broader CI context is needed. (role: adjacent CI contributor; confidence: medium; commits: 2c62955864af, 4847c0c19542, 4a1935de5df4; files: .github/workflows/ci.yml)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. labels Jun 23, 2026
@Yuxin-Qiao

Copy link
Copy Markdown
Contributor Author

Added exact-head GitHub Actions proof to the PR body.

The completed run for 924046af311d24fa13e1b6c88e2764e0d1782207 is green, and every newly added summary step completed successfully in the real PR workflow:

  • Summarize macOS test gate
  • both Summarize Linux CLI build matrix jobs
  • all four Summarize macOS shard matrix jobs
  • Summarize aggregate CI gate

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 23, 2026

Copy link
Copy Markdown

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@steipete
steipete merged commit f2dede1 into steipete:main Jun 23, 2026
10 checks passed
@Yuxin-Qiao
Yuxin-Qiao deleted the codex/ci-summary-observability branch June 25, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants