chore: split the label manifest into baseline and per-repo overlays - #69
Merged
Conversation
labels.yml mixed org-wide process labels with ones only meaningful in the application repo, so opting folio or a Rust package into the sync would have created an 'outlook plugin' label in a DOCX library. Split it: labels.yml is the baseline every repo gets, labels/<repo>.yml carries product-specific additions and is merged on top, overlay winning on a name collision. labels/stella.yml also declares the sixteen labels stella/stella already carried but the manifest had never heard of (react-doctor, docx-editor, i18n, the CI bot labels). Those previously survived a prune only because prune skips labels still in use; now they survive because they are declared, which makes apply-with-prune meaningful rather than merely safe. Also let plan preview deletions. Prune previously ran only in apply-with-prune, which deletes immediately, so a destructive run could not be reviewed before it happened.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #66 and #67.
labels.ymlmixed org-wide process labels with ones only meaningful inside the application repo, so optingfolioor a Rust package into the sync would have created an "outlook plugin" label in a DOCX library. That is why #66 defaulted the target tostellarather thanall.The split
The script reads the baseline, then merges
labels/<repo>.ymlon top when it exists. An overlay entry wins on a name collision, so a repo can retune a shared label without forking the manifest.Moved to the overlay:
🤖 AI,🎨 ux,🔌 external data,📬 outlook plugin,🧮 table. Promoted into the baseline:run-pr-lintandinvalid, which are governance and a GitHub default rather than product surface.Declaring what was already there
labels/stella.ymlalso declares eleven labelsstella/stellahas carried all along that the manifest had never heard of: the sixreact-doctor: *CI labels,📝 docx-editor,🌍 i18n,🐞 bug,agent-feedback, andjavascript.They previously survived a prune only because prune skips labels still in use. Now they survive because they are declared. That is the difference between
apply-with-prunebeing safe and being meaningful: anything undeclared is now undeclared on purpose.plan can preview deletions
Prune previously ran only under
apply-with-prune, which deletes immediately, so there was no way to review a destructive run before it happened.plannow reports prune candidates and writes nothing; onlyapply-with-prunedeletes.Verification
Local
planagainst both repo shapes.stella/stella, which has an overlay and was synced this morning:Zero on every counter is the load-bearing result: baseline plus overlay reproduces the live state exactly, so the split introduced no drift.
prune=0confirms the overlay accounts for every label actually present.stella/folio, which has no overlay:Baseline only. No
📬 outlook plugin, no🧮 table, noreact-doctor: *. That is the whole point of the split.shellcheckclean.After merge
The
stella/stellacaller pins the reusable workflow to a SHA, and this PR changes that workflow (the sparse checkout needslabels/). The pin must be bumped in a follow-up or the overlay will not be checked out and the sync will silently fall back to baseline only.