Skip to content

[FIX 1.9.24] Disable memo for all M addresses#602

Merged
leofelix077 merged 4 commits intorelease/v1.9.24from
lf-1.9.24-disable-memo-all-m-address
Dec 4, 2025
Merged

[FIX 1.9.24] Disable memo for all M addresses#602
leofelix077 merged 4 commits intorelease/v1.9.24from
lf-1.9.24-disable-memo-all-m-address

Conversation

@leofelix077
Copy link
Copy Markdown
Collaborator

@leofelix077 leofelix077 commented Dec 4, 2025 •
edited
Loading

Screen.Recording.2025-12-04.at.15.50.42.mov
Screen.Recording.2025-12-04.at.15.52.04.mov

PR structure

  • This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not).
  • This PR has reasonably narrow scope (break it down into smaller PRs if not).
  • This PR includes relevant before and after screenshots/videos highlighting these changes.
  • I took the time to review my own PR.

Testing

  • These changes have been tested and confirmed to work as intended on Android.
  • These changes have been tested and confirmed to work as intended on iOS.
  • These changes have been tested and confirmed to work as intended on small iOS screens.
  • These changes have been tested and confirmed to work as intended on small Android screens.
  • I have tried to break these changes while extensively testing them.
  • This PR adds tests for the new functionality or fixes.

Release

  • This is not a breaking change.
  • This PR updates existing JSDocs when applicable.
  • This PR adds JSDocs to new functionalities.
  • I've checked with the product team if we should add metrics to these changes.
  • I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes.

@leofelix077 leofelix077 self-assigned this Dec 4, 2025
@leofelix077 leofelix077 added the bug Something isn't working label Dec 4, 2025
@leofelix077
Copy link
Copy Markdown
Collaborator Author

leofelix077 commented Dec 4, 2025

@CassioMG as discussed through Slack, disabling memo for pre-CAP67 contracts was not properly working, such as for Meridian Pay collectibles. I have adjusted the code now

Screen.Recording.2025-12-04.at.17.31.43.mov

CassioMG
CassioMG approved these changes Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CassioMG CassioMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leofelix077 leofelix077 merged commit 7bbbfd8 into release/v1.9.24 Dec 4, 2025
6 checks passed
@leofelix077 leofelix077 deleted the lf-1.9.24-disable-memo-all-m-address branch December 4, 2025 21:34
This was referenced Dec 4, 2025
Closed
Closed
Closed
CassioMG added a commit that referenced this pull request Dec 4, 2025
@github-actions @CassioMG @leofelix077
v1.9.24 (#592)
46159f6 
* chore: bump app version to v1.9.24

* Trigger CI tests

* [iOS Workflow] Improve Xcode selection (#598)

* [iOS Workflow] Improve Xcode stable version selection

* Ensure dSYM file is generated

* Fix destination address memo and fiat input conversion (#597)

* Fix destination address memo and fiat input conversion

* update fiat conversion reducer and refactor into smaller functions

* update code to disable memo only for soroban transactions

* simplify comment

* move isSorobanTransaction check to a helper function

* add unit tests for isSorobanTransaction

* [1.9.24] Fix Fiat input + add highlighting (#601)

* fix fiat input and add input highlighting

* fix highlighting for decimal/small amounts

* add token amount formatting function for display

* [FIX 1.9.24] Disable memo for all M addresses (#602)

* disable memo for all M addresses (classic + soroban transactions)

* handle disable memo for pre-cap67 contract addresses (e.g. MP collectibles)

* update tests for muxed address scenarios

* update tests for muxed address scenarios

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cássio Marcos Goulart <cassiomgoulart@gmail.com>
Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com>
Co-authored-by: leofelix077 <leonardoaalf077@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CassioMG CassioMG CassioMG approved these changes

@aristidesstaffieri aristidesstaffieri Awaiting requested review from aristidesstaffieri

Assignees

@leofelix077 leofelix077

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leofelix077 @CassioMG