v1.9.28#606
Closed
github-actions[bot] wants to merge 9 commits intomainfrom
Closed
Conversation
* [iOS Workflow] Improve Xcode stable version selection * Ensure dSYM file is generated
* Fix destination address memo and fiat input conversion * update fiat conversion reducer and refactor into smaller functions * update code to disable memo only for soroban transactions * simplify comment * move isSorobanTransaction check to a helper function * add unit tests for isSorobanTransaction
* fix fiat input and add input highlighting * fix highlighting for decimal/small amounts * add token amount formatting function for display
* disable memo for all M addresses (classic + soroban transactions) * handle disable memo for pre-cap67 contract addresses (e.g. MP collectibles) * update tests for muxed address scenarios * update tests for muxed address scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Changes