Manage Assets Data Flow#96
Conversation
…nage-assets-data-flow
Brunonascdev
requested review from
CassioMG,
aristidesstaffieri,
Copilot,
danilosilvackl and
piyalbasu
There was a problem hiding this comment.
Pull Request Overview
This PR implements the data flow for the Manage Assets feature by introducing new asset management UI components and removing legacy logic. Key changes include the creation of new components (ErrorState, EmptyState, AssetItem, AddAssetRightContent, and AddAssetBottomSheetContent), updates to the SimpleBalancesList to incorporate asset removal features, and various improvements and refactoring in supporting primitives and configurations.
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/screens/HistoryScreen.tsx | Removed logout functionality and unused imports to simplify the screen. |
| src/components/screens/AddAssetScreen/* | Introduced new asset-related screens and types to support asset management. |
| src/components/primitives/Menu.tsx | Added MenuGroup and MenuSeparator components utilizing nested menu items. |
| src/components/SimpleBalancesList.tsx | Updated to filter and display balance items with the new ManageAssetRightContent. |
| src/components/Modal.tsx | Created a new Modal component for consistent UI presentation. |
| src/components/ManageAssetRightContent.tsx | Added a component to handle asset actions via a context menu and modal flows. |
| src/components/ContextMenuButton.tsx | Enhanced handling of nested menu actions and added key generation logic. |
| src/components/BottomSheet.tsx | Updated props and styling to increase configurability and align with theme. |
| eslint.config.mjs | Adjusted imports and added a new ESLint rule disable for exports. |
| tests/* | Updated tests to reflect changes in component props and rendering setup. |
danilosilvackl
left a comment
danilosilvackl
left a comment
There was a problem hiding this comment.
looking very neat! left some suggestions
* feat: add calculateSpacing function to handle different devices * refactor: remove unnecessary spacing constant * refactor: remove unnecessary styled-components component * feat: pr suggested improvements
|
@Brunonascdev for the Custom Token case I think we should replace "Trustline" with something else as it only makes sense for classic assets. I think we also don't currently support trading Custom Tokens, do we? How is the copy looking on the extension while adding a custom token? 
|
@Brunonascdev I think we'll also need to rename some functions like |
it's very different from the mobile version: adding USDC: adding a custom soroban token: |
|
For future reference: We’ve aligned on updating the copy in the Add Asset BottomSheet to remove any mention of “trustlines,” since no ChangeTrust operation is triggered when adding a custom Soroban token. Here’s the revised copy currently in place: 
|
CassioMG
left a comment
CassioMG
left a comment
There was a problem hiding this comment.
LGTM - great job on this @Brunonascdev! 🚀 🚀 🚀
This PR implements the data flow for the Manage Assets feature. It allows the user to add different assets categories (classic and SAC) using the Stellar Expert and Freighter Backend APIs.
closes issue #73
Android
manage-assets-flow-android.webm
iOS
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-04-15.at.11.47.24.mp4
Adding Soroban Custom Asset
adding-soroban-asset.webm