Fix spacing inconsistencies across different devices#97
Merged
Brunonascdev merged 6 commits intobn-manage-assets-data-flowfrom Apr 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes spacing inconsistencies across different devices and makes several updates to UI components and helper functions. Key changes include new spacing calculation logic using calculateSpacing, removal of the legacy AddAssetScreen component, and updates to context menu and bottom sheet components for improved consistency.
Reviewed Changes
Copilot reviewed 59 out of 61 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/screens/AddAssetRightContent.tsx | Introduces a new button component with updated spacing and icon usage. |
| src/components/screens/AddAssetBottomSheetContent.tsx | Adds new bottom sheet content with updated spacing and layout tweaks. |
| src/components/screens/AddAssetScreen.tsx | Removed legacy AddAssetScreen component as part of the spacing correction effort. |
| src/components/primitives/Menu.tsx | Adds padding to the menu trigger for improved tap target area. |
| src/components/layout/OnboardLayout.tsx, BaseLayout.tsx, CustomNavigationHeader.tsx | Replaces direct insets with calculateSpacing for consistency across devices. |
| src/components/Spinner.tsx, Modal.tsx, ManageAssetRightContent.tsx | New and updated components that conform to the refresh spacing strategy. |
| src/components/ContextMenuButton.tsx, BottomSheet.tsx | Enhances menu behavior and adds new optional props for the bottom sheet. |
| Jest setup and tests | Updates testing utils and mocks to align with the new spacing logic and component props. |
Files not reviewed (2)
- ios/freighter-mobile/PrivacyInfo.xcprivacy: Language not supported
- package.json: Language not supported
Contributor
|
@Brunonascdev should this PR be pointing to |
Contributor
Author
makes sense. I just changed the base. |
…x-spacing-inconsistencies-across-devices
CassioMG
reviewed
Apr 21, 2025
CassioMG
reviewed
Apr 21, 2025
CassioMG
reviewed
Apr 21, 2025
Brunonascdev
added a commit
that referenced
this pull request
Apr 23, 2025
* feat: add search asset function * feat(wip): asset screen done, missing stellar sdk integration * feat(wip): add changeTrust tx creation and submission * refactor: general improvements and useColors hook * feat: merge with main branch * feat: add remove asset feature * fix: jest issues with toastprovider * feat: add modal component * feat: pr suggested improvements * feat: create useManageAssets hook * Fix spacing inconsistencies across different devices (#97) * feat: add calculateSpacing function to handle different devices * refactor: remove unnecessary spacing constant * refactor: remove unnecessary styled-components component * feat: pr suggested improvements * feat: create useAssetLookup hook for searching contracts and tokens * feat: add Custom Token capabilities * feat: move AssetTypeWithCustomToken type to a enum * feat: add decimals and fix error on fetch prices endpoint call * refactor: rewrite storage typings comment * feat: make remove asset parameter unique * feat: adjust trustlines copy and general pr requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix spacing inconsistencies across different devices
closes issue #93 and #92
iOS (iPhone 14 Pro)
ScreenRecording_04-17-2025.13-44-55_1.MP4
Android (Galaxy S21)
Screen_Recording_20250417_135303_Freighter.mp4
iOS Small (iPhone SE)
Simulator.Screen.Recording.-.smalliphone.-.2025-04-17.at.14.39.13.mp4
Android Small (720x1280)
smallandroid.webm