Skip to content

Auto Focus password fields#2669

Merged
leofelix077 merged 4 commits intomasterfrom
feature/auto-focus-login-input
Mar 30, 2026
Merged

Auto Focus password fields#2669
leofelix077 merged 4 commits intomasterfrom
feature/auto-focus-login-input

Conversation

@leofelix077
Copy link
Copy Markdown
Collaborator

@leofelix077 leofelix077 commented Mar 27, 2026

Closes #2565

Screen.Recording.2026-03-27.at.13.44.23.mov
Screen.Recording.2026-03-27.at.16.00.05.mov

@leofelix077 leofelix077 self-assigned this Mar 27, 2026
Copilot AI review requested due to automatic review settings March 27, 2026 18:43
@leofelix077 leofelix077 added the enhancement New feature or request label Mar 27, 2026
@leofelix077 leofelix077 changed the title Auto Focus Lock Screen Password Input Auto Focus password field when wallet popup opens Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds automatic focus to the unlock screen password field so users can start typing immediately when the extension popup opens (closes #2565).

Changes:

  • Set the password Input in EnterPassword to autoFocus.
  • Add an E2E test asserting the unlock-screen password field is focused after logout.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
extension/src/popup/components/EnterPassword/index.tsx Adds autoFocus to the shared password entry component used on the unlock screen (and other password prompts).
extension/e2e-tests/login.test.ts Adds a Playwright test to verify the unlock password input receives focus.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leofelix077 leofelix077 changed the title Auto Focus password field when wallet popup opens Auto Focus password field Mar 27, 2026
@leofelix077 leofelix077 added the don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review label Mar 27, 2026
isPassword
fieldSize="md"
autoComplete="off"
autoFocus
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added for both pw fields for consistency

on lock screen and when entering the show recovery phrase

@leofelix077 leofelix077 changed the title Auto Focus password field Auto Focus password fields Mar 27, 2026
Copy link
Copy Markdown
Contributor

@CassioMG CassioMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the first video on the PR is cut and not showing the cursor

@leofelix077
Copy link
Copy Markdown
Collaborator Author

@CassioMG updated it now with the right video

@leofelix077 leofelix077 merged commit 3954fb9 into master Mar 30, 2026
9 checks passed
@leofelix077 leofelix077 deleted the feature/auto-focus-login-input branch March 30, 2026 12:47
@github-actions github-actions bot mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

don't review yet wip / tests in progress / missing videos or screenshots / pending self code-review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto focus password field when wallet popup opens

3 participants