Conversation
…e some small adjustments to auth flow
piyalbasu
commented
May 20, 2020
| `/index.html#/sign-transaction?${encodetransactionInfo}`, | ||
| ), | ||
| "Lyra: Sign Transaction", | ||
| WINDOW_DIMENSIONS, |
Contributor
Author
There was a problem hiding this comment.
open these views in a new mini window instead of just a new tab
piyalbasu
commented
May 20, 2020
| <HomeRoute /> | ||
| <RecoverAccount /> | ||
| </Route> | ||
| <HomeRoute /> |
Contributor
Author
There was a problem hiding this comment.
fixing some routing issues when jumping back into auth flow
piyalbasu
commented
May 20, 2020
| @@ -1,15 +1,227 @@ | |||
| import connect from "./connect"; | |||
Contributor
Author
There was a problem hiding this comment.
this is just renaming the folder from 'services' to 'api'. since there was already an 'api' folder, it did a diff. ignore!
piyalbasu
commented
May 20, 2020
| @@ -0,0 +1,23 @@ | |||
| import React from "react"; | |||
Contributor
Author
There was a problem hiding this comment.
added a quick css tooltip component; not sure if we'll end up using it in the long run, but helpful for the moment
piyalbasu
commented
May 20, 2020
| @@ -0,0 +1,15 @@ | |||
| import React from "react"; | |||
Contributor
Author
There was a problem hiding this comment.
this will end up being where we stylize all error messages
piyalbasu
commented
May 20, 2020
|
|
||
| &:hover + ${StyledTooltip} { | ||
| visibility: visible; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
blur the public key by default; we'll show the tooltip to let the user know clicking will reveal it
piyalbasu
added a commit
that referenced
this pull request
Apr 1, 2026
Medium #1 – Remove dead message-based SIDEBAR_REGISTER/UNREGISTER The port-based registration (initSidebarConnectionListener) already handles window-ID tracking with reliable disconnect cleanup. The redundant message-based handlers were dead code and added unnecessary attack surface. Removed the case handlers, the SidebarRegisterMessage / SidebarUnregisterMessage types, their ServiceMessageRequest union entries, and the SIDEBAR_REGISTER/SIDEBAR_UNREGISTER enum values. Medium #2 – openSidebar() no longer closes popup on API failure Moved window.close() inside the try block so the popup only closes after the sidebar API calls succeed. Errors are logged and the popup stays open, leaving the user with usable UI. Medium #3 – isSidebarMode() now requires extension origin Added a protocol check (chrome-extension:// or moz-extension://) before inspecting the ?mode=sidebar query param, preventing the sidebar code path from activating in unexpected non-extension environments (e.g. test runners, web views). Low #1 – Fix unsafe boolean cast in initSidebarBehavior localStorage.getItem returns a string. The previous 'as boolean' cast would coerce any non-empty string (including 'false') to true. Now compared explicitly with === 'true'. Low #2 – Add tests for sidebar message handlers Five new tests in sidebar.test.ts cover: OPEN_SIDEBAR rejection for content-script senders, OPEN_SIDEBAR success for extension-page senders, and sidebarWindowId set/clear lifecycle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.