Skip to content

Bugfix: Signature hints should append zeroes rather than prepend them#523

Merged
Shaptic merged 2 commits intoprotocol-19from
prepend-hint
Apr 7, 2022
Merged

Bugfix: Signature hints should append zeroes rather than prepend them#523
Shaptic merged 2 commits intoprotocol-19from
prepend-hint

Conversation

@Shaptic
Copy link
Copy Markdown
Contributor

@Shaptic Shaptic commented Apr 6, 2022 •
edited
Loading

This wasn't caught by tests because

describe('', function() {
  it('', function() {
    it('', function() { 
    });
  });
});

will not run the inner set of its... 🤦

@Shaptic Shaptic added the bug label Apr 6, 2022
@Shaptic Shaptic requested a review from paulbellamy April 6, 2022 18:12
@Shaptic Shaptic self-assigned this Apr 6, 2022
paulbellamy
paulbellamy approved these changes Apr 7, 2022
View reviewed changes
Comment thread src/keypair.js
@Shaptic Shaptic merged commit 78ef2e5 into protocol-19 Apr 7, 2022
@Shaptic Shaptic deleted the prepend-hint branch April 7, 2022 16:16
Shaptic added a commit that referenced this pull request Apr 11, 2022
@Shaptic
Merge Protocol 19 features into master: (#521)
96e0c3b 
* Update XDR definitions and relevant code for Protocol 19 (#509)
* Add support for signed payload signer keys to `StrKey` (#511)
* Support new preconditions when using building transactions (#513)
* Add conversion layer between `xdr.SignerKey`s and `StrKey`s (#520, #523)

Co-authored-by: Paul Bellamy <paul@stellar.org>
@Shaptic Shaptic mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@paulbellamy paulbellamy paulbellamy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Shaptic Shaptic

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shaptic @paulbellamy