Rename token example's approve arg to live_until_ledger - #415
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
September 9, 2026 06:45
leighmcculloch
enabled auto-merge (squash)
September 9, 2026 06:46
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the token example’s allowance terminology with Soroban SDK v27 and SEP-41 while retaining the existing event schema.
Changes:
- Renames the
approveargument and internal allowance field tolive_until_ledger. - Preserves the event field name
expiration_ledger.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
token/src/storage_types.rs |
Renames the stored allowance field. |
token/src/contract.rs |
Updates approve while preserving event compatibility. |
token/src/allowance.rs |
Propagates the renamed field through allowance logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmkozh
approved these changes
Sep 9, 2026
Member
Author
|
Follow up in the stellar-docs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the
approveallowance parameter and its internal storage field in the token example fromexpiration_ledgertolive_until_ledger.Why
The soroban-sdk v27.0.1 (stellar/rs-soroban-sdk#1932) renamed this argument on both
TokenInterfaceandStellarAssetInterfaceto align with the SEP-41 spec and this is just keeping the names updated everywhere we can.The event field still has the old name because that was updated in v28 of the sdk, so we can't update it yet here where the examples are still on v27.
Known limitations
N/A