update stellar-sdk version in binding generation#2640
Open
Ryang-21 wants to merge 3 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript bindings template used by soroban-spec-typescript so that newly generated TS contract binding projects depend on @stellar/stellar-sdk v16.0.1 (Protocol 27 line), aligning generated bindings with the CLI’s Protocol 27 support and avoiding manual package.json edits by users.
Changes:
- Bump
@stellar/stellar-sdkdependency from^14.5.0to^16.0.1in the TypeScript bindings project template. - Update the same SDK version pin in TypeScript fixture projects used for validation/golden outputs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/crates/soroban-spec-typescript/src/project_template/package.json | Updates the default SDK dependency for newly generated TypeScript bindings projects. |
| cmd/crates/soroban-spec-typescript/fixtures/test_custom_types/package.json | Keeps fixture project dependency pin aligned with the template’s SDK version. |
| cmd/crates/soroban-spec-typescript/fixtures/test_constructor/package.json | Keeps fixture project dependency pin aligned with the template’s SDK version. |
| }, | ||
| "dependencies": { | ||
| "@stellar/stellar-sdk": "^14.5.0", | ||
| "@stellar/stellar-sdk": "^16.0.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updated the stellar-sdk version to v16.0.1 in binding generator
Why
So that users generating contract bindings do not have to manually alter the package.json
Closes #2639