Skip to content

Bugfixes for e2e tests in release/v0.3.0 branch#294

Merged
leighmcculloch merged 5 commits intorelease/v0.3.0from
release/v0.3.0-bugfixes
Dec 6, 2022
Merged

Bugfixes for e2e tests in release/v0.3.0 branch#294
leighmcculloch merged 5 commits intorelease/v0.3.0from
release/v0.3.0-bugfixes

Conversation

@paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Dec 6, 2022

What

  • Fix bug in soroban deploy --wasm-hash sequence calculation introduced in eadacec
  • Fix conflicting contract ids in e2e tests
    • The token contract and the newly installed one were using the same salt, resulting in a conflict between the tests.
  • Use the temporary stellar/quickstart:pr-389-soroban-dev to run e2e tests so they work for now.
  • Remove hardcoded --salt params from e2e tests altogether.
    • This means the cli will autogenerate a random salt for each one.
    • The e2e tests are then independent from each other and are less likely to conflict.
    • The e2e do not need a clean network to run anymore.

Why

To fix the e2e tests for #291

Known limitations

[TODO or N/A]

@paulbellamy paulbellamy force-pushed the release/v0.3.0-bugfixes branch from 545d00f to 04eab72 Compare December 6, 2022 12:00
@leighmcculloch leighmcculloch merged commit a6d2f21 into release/v0.3.0 Dec 6, 2022
@leighmcculloch leighmcculloch deleted the release/v0.3.0-bugfixes branch December 6, 2022 14:51
paulbellamy pushed a commit that referenced this pull request Dec 6, 2022
* Bump version to 0.3.0

* Bump soroban-rpc version to 0.3.0

* Don't publish soroban-tools

* Remove soroban-tools

* Remove soroban-tools

* fix build.rs

* fix build.rs

* undo changing version that should be injected during build

* Bugfixes for e2e tests in release/v0.3.0 branch (#294)

* Fix account sequence numbers when deploy --wasm-hash

Fixes #290
Fixes regression introduced in eadacec

* Fix conflicting contract ids in e2e tests

* Stop hard-coding salts in e2e tests to make them more robust

This also means they are now independent, and do not need a clean
network to run.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Paul Bellamy <paul@stellar.org>
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants