🧹 Clean up software-versions organization - #2675
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
Reorganizes software-version history and improves changelog references, with ancillary URL normalization.
Changes:
- Groups releases by protocol and network.
- Adds links to historical changes.
- Normalizes external URLs.
Recommendation: NEEDS-CHANGES — correct the Testnet passphrase claim and malformed anchor.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
docs/networks/software-versions.mdx |
Reorganizes releases and adds references. |
docs/validators/admin-guide/monitoring.mdx |
Normalizes Radar URL. |
docs/validators/admin-guide/configuring.mdx |
Normalizes Radar URL. |
docs/data/apis/rpc/providers.mdx |
Simplifies provider URLs. |
retrieve-a-payment.StatusCodes.json |
Normalizes documentation URLs. |
list-all-payments.StatusCodes.json |
Normalizes documentation URLs. |
list-all-disbursement-receivers.StatusCodes.json |
Normalizes documentation URLs. |
create-direct-payment.StatusCodes.json |
Normalizes documentation URLs. |
Co-authored-by: Codex <noreply@openai.com>
ElliotFriend
left a comment
There was a problem hiding this comment.
Thanks, John! the software-versions.mdx reorganization is very much appreciate. This is something i've been thinking through lately, and it's good to see some others are also wanting some improvements to the page.
One ask before I review, though. Alongside the reorg, the PR also edits URLs in seven other files, mostly trailing-slash removals. A couple of reasons I'd rather not take those here:
- We've landed on keeping unrelated URL normalization out of feature PRs before (see #2583 and #2396), so this isn't really a new call. A batch of cosmetic URL edits riding along in an unrelated reorg makes the diff harder to review for the change that actually matters.
- The four
*.StatusCodes.jsonfiles are generated from the SDP API spec. We edit the OpenAPI source and regenerate rather than hand-editing the output, otherwise those edits get overwritten the next time the reference is regenerated. - The Alchemy link in
providers.mdxalso drops its?utm_source=chain_partner&utm_medium=referral…params. that's a partner referral link, so I don't want to change it without a specific reason.
To be clear, there's nothing wrong with preferring URLs without trailing slashes, and if you tidy one up while you're already editing a page, that doesn't bother me at all. It's specifically the standalone sweep, bundled into unrelated work, that I'd like to keep out.
If you drop those seven files so this is just the software-versions cleanup, I can get it reviewed. Thanks again!
Co-authored-by: Codex <noreply@openai.com>
No description provided.