Add NFT proposal for soroban (ERC-721)#1405
Conversation
|
|
||
| ```rust | ||
| pub trait Interface { | ||
| fn balance_of(env: Env, owner: Address) -> u32; |
There was a problem hiding this comment.
Why not balance for consistency with token interface?
| ## Specification | ||
|
|
||
| ```rust | ||
| pub trait Interface { |
| ```rust | ||
| pub trait Interface { | ||
| fn balance_of(env: Env, owner: Address) -> u32; | ||
| fn transfer_from(env: Env, spender: Address, from: Address, to: Address, token_id: u32); |
There was a problem hiding this comment.
There should be a transfer function as it's probably the main interface for Soroban.
| ```rust | ||
| pub trait Interface { | ||
| fn balance_of(env: Env, owner: Address) -> u32; | ||
| fn transfer_from(env: Env, spender: Address, from: Address, to: Address, token_id: u32); |
There was a problem hiding this comment.
What is the rationale for using the approve for NFTs? For tokens the use case for it is to mostly some edge cases, like subscriptions.
| pub trait Interface { | ||
| fn balance_of(env: Env, owner: Address) -> u32; | ||
| fn transfer_from(env: Env, spender: Address, from: Address, to: Address, token_id: u32); | ||
| fn approve( |
There was a problem hiding this comment.
Why operator is optional here?
| fn set_approval_for_all( | ||
| env: Env, | ||
| caller: Address, | ||
| owner: Address, |
|
|
||
| This proposal defines a standard interface that NFTs on Soroban powered | ||
| networks, such as the Stellar network, can implement to interoperate with | ||
| contracts that use NFTs, and Stellar assets. |
There was a problem hiding this comment.
What is the plan for the Stellar assets interop?
There was a problem hiding this comment.
I made a PR to try to enable SAC interop.
vinamogit#2
namankumar
changed the title
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
3 participants
Following #1402 for NFTs.