Skip to content

Conversation

@dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jan 15, 2026

There was some inconsistency around min_extension that I've clarified.

Also clarify the validation logic and justification for temporary entries.

Copilot AI review requested due to automatic review settings January 15, 2026 20:22
There was some inconsistency around `min_extension` that I've clarified.

Also clarify the validation logic and justification for temporary entries.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clarifies inconsistencies in the CAP-78 specification around min_extension and updates the TTL extension algorithm validation logic. The changes improve the clarity of how TTL extensions are computed and validated, particularly for temporary entries.

Changes:

  • Clarified the TTL extension algorithm, simplifying the logic flow and adding explicit network limit computation
  • Updated documentation to better explain the difference between min_extension and the old threshold parameter
  • Added justification for validation behavior differences between network limits and user-provided arguments for temporary entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dmkozh and others added 3 commits January 15, 2026 16:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@anupsdf
Copy link
Contributor

anupsdf commented Jan 16, 2026

If in future TTL would be reimagined as time-based instead of number of ledgers, I wonder if we should do this CAP.

@dmkozh
Copy link
Contributor Author

dmkozh commented Jan 16, 2026

If in future TTL would be reimagined as time-based instead of number of ledgers, I wonder if we should do this CAP.

I don't think so. I'm not sure yet about the feasibility of time-based TTLs, and in general it seems like a topic that will take a while to figure out and agree on. This CAP is a quick win for the existing users, and if it works well, the time-based functions could resemble this interface (or we could even make the interface polymorphic).

@dmkozh dmkozh enabled auto-merge (squash) January 16, 2026 20:01
@dmkozh dmkozh merged commit 1013e9c into stellar:master Jan 16, 2026
5 checks passed
@dmkozh dmkozh deleted the cap78_upd branch January 16, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants