Temporarily allow soroban upgrade setup to fail - #181
Merged
Conversation
bboston7
approved these changes
Jul 15, 2024
Jonathan-Eid
added a commit
to Jonathan-Eid/supercluster
that referenced
this pull request
Aug 11, 2026
Every run shipped two log files: http_server_<stamp>.log holding the whole monitor's output, and job_monitor_<stamp>.log holding nothing. Seen in run stellar#181 at 13.27 KiB and 0 B, and reproduced locally. build_logger calls logging.basicConfig, which is a no-op once the root logger has handlers. job_monitor imports http_server before configuring itself, so http_server's call ran first and won; job_monitor's was discarded. The FileHandler it had already constructed still created and opened its file, which is why an empty one appeared. Both modules take the ROOT logger, so everything landed in the file named after whichever module imported first. The entrypoint should configure logging and nothing else should. http_server now takes a plain named logger, so job_monitor's build_logger is the first and only call: one file, job_monitor_<stamp>.log, carrying both modules' records. Verified -- one file, 276 bytes, records from both. Image rebuilt as 2026-08-11a and pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows loadgen to succeed if setting up the Soroboan upgrade contract fails. This is a temporary fix for Max TPS test until we figure out the root cause of the Soroban upgrade bug.