Switch to new trigger timer flag format - #421
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates trigger-timer configuration for protocol 28 while preserving protocol-based defaults.
Changes:
- Replaces the experimental timer flag with the new force-old-style flag.
- Updates consensus-mix behavior and defaults.
- Refreshes configuration tests, CLI help, and documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/FSLibrary/StellarMissionContext.fs |
Renames mission timer settings. |
src/FSLibrary/StellarCoreSet.fs |
Updates CoreSet timer option. |
src/FSLibrary/StellarCoreCfg.fs |
Emits the new stellar-core configuration field. |
src/FSLibrary/MissionTriggerTimerMixConsensus.fs |
Inverts timer-mix selection to force old-style nodes. |
src/FSLibrary/MaxTPSTest.fs |
Removes unconditional experimental timer activation. |
src/FSLibrary.Tests/Tests.fs |
Updates timer configuration tests. |
src/App/Program.fs |
Replaces CLI options and defaults. |
doc/missions.md |
Documents the protocol-28 timer controls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sisuresh
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix experimental flag to use the new field name in p28. Note that previously, we always ran SSC missions with the new trigger timer enabled. Now, we will only use the flag for p28 builds.