Use startup probe to delay liveness probe during core setup - #8
Merged
Conversation
marta-lokhova
force-pushed
the
startupProbe
branch
from
July 14, 2021 20:15
1bf96e8 to
8271911
Compare
Jonathan-Eid
added a commit
to Jonathan-Eid/supercluster
that referenced
this pull request
Aug 10, 2026
They were split across Tests.fs and TestsRace8.fs, a file named for the defect that prompted it rather than for what it covers. Both now live in one file named for its subject, and the RACE stellar#8 rationale survives as its header -- it explains why the profile-projection tests assert what they do, which is not obvious from the assertions. The block was already self-contained: no reference to ctx, coreSet or any other Tests.fs helper, so this is a move. Tests.fs loses its MissionHistoryPubnetParallelCatchupV2 open, now unused; the pubnetParallelCatchup fields in its MissionContext literal stay, because F# records need every field. Verified as a move rather than a rewrite: same 32 tests, and reintroducing the defect the profile tests exist for -- attaching count before the `entry.Count > 0` guard -- still fails exactly 5 of them from the new file. Also adds HANDOFF.md, which is what the Jenkinsfile needs now that capacity is passed rather than derived: both pool-claim maps verbatim, the three options every pooled run must set, and which failures are loud (a tier missing from a map fails /start with a reason) versus silent (an omitted capacity label lands a spot run on on-demand nodes). Pins the job-monitor image to 2026-08-10a, which carries REQUIRE_NODE_LABELS and the /start pool-map check. Still a personal Docker Hub repo, still a dev pin.
Jonathan-Eid
added a commit
to Jonathan-Eid/supercluster
that referenced
this pull request
Aug 10, 2026
Unlike the eight cut before it, this one was not redundant: it was the sole killer of two mutants, and both now survive. Dropping peakEphemeralBytes or peakWorkingSetBytes from rangeProfileFields no longer fails anything. What that costs, so it is not rediscovered the hard way: the artifact would still be written, still carry the right number of ranges, and still look complete, while the next run sizes every range from defaults on the missing axis. That is the RACE stellar#8 failure shape -- nothing downstream can tell a measurement-free profile from a good one -- narrowed to one field. drop-seconds and volume-peak-profiled are still covered, by "a measured run still produces a complete profile" and "range profile does not carry a pvc volume peak" respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.