Skip to content

fix: count LangSmith trace URL coverage - #2124

Merged
stranske merged 2 commits into
mainfrom
sync-review-1836-langsmith-url
May 15, 2026
Merged

fix: count LangSmith trace URL coverage#2124
stranske merged 2 commits into
mainfrom
sync-review-1836-langsmith-url

Conversation

@stranske

Copy link
Copy Markdown
Owner

Summary

  • Count non-empty LangSmith trace URLs as trace coverage when a trace ID is absent
  • Apply the same helper change to the consumer template copy
  • Add tests for top-level URL-only records and URL-only trace-list entries

Addresses active review feedback from sync consumer PR stranske/Pension-Data#443.

Validation

  • python -m pytest tests/scripts/test_aggregate_agent_metrics.py -q
  • python -m ruff check scripts/aggregate_agent_metrics.py tests/scripts/test_aggregate_agent_metrics.py templates/consumer-repo/scripts/aggregate_agent_metrics.py
  • diff -u scripts/aggregate_agent_metrics.py templates/consumer-repo/scripts/aggregate_agent_metrics.py

Copilot AI review requested due to automatic review settings May 15, 2026 07:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Runner dispatch state for codex on PR #2124. Do not edit.

@agents-workflows-bot

agents-workflows-bot Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: ad21ffe
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants