Skip to content

fix: preserve sync test dependency stdlib detection - #1994

Closed
stranske wants to merge 1 commit into
mainfrom
sync-test-deps-review-1013
Closed

fix: preserve sync test dependency stdlib detection#1994
stranske wants to merge 1 commit into
mainfrom
sync-test-deps-review-1013

Conversation

@stranske

@stranske stranske commented May 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • use Python's stdlib module inventory plus fallback allowlist in sync_test_dependencies
  • restore jwt -> PyJWT dependency mapping
  • add focused regression coverage for html/http/secrets and jwt imports

Validation

  • python -m pytest tests/scripts/test_sync_test_dependencies.py tests/scripts/test_sync_test_dependencies_mapping.py -q
  • python -m ruff check scripts/sync_test_dependencies.py templates/consumer-repo/scripts/sync_test_dependencies.py tests/scripts/test_sync_test_dependencies.py tests/scripts/test_sync_test_dependencies_mapping.py

Copilot AI review requested due to automatic review settings May 4, 2026 07:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@stranske
stranske temporarily deployed to agent-standard May 4, 2026 07:32 — with GitHub Actions Inactive
@agents-workflows-bot

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: c6bdb16
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske

Copy link
Copy Markdown
Owner Author

Closing as superseded by #2117, which carried the stdlib dependency detection / jwt to PyJWT mapping fix forward onto current main, passed focused tests and Gate, and merged in aa5fca7.

@stranske stranske closed this May 14, 2026
@stranske
stranske deleted the sync-test-deps-review-1013 branch May 14, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants