fix: carry forward sync review followups - #2117
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR carries forward sync dependency follow-ups and hardens the keepalive draft-ready mutation test while keeping repo and consumer template scripts aligned.
Changes:
- Uses runtime stdlib inventory plus fallback module names in sync dependency scripts.
- Adds/updates regression coverage for stdlib imports and
jwt→PyJWTmapping. - Strengthens GraphQL mutation brace-balance validation in the keepalive gate runner test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
scripts/sync_test_dependencies.py |
Updates stdlib module detection to combine runtime inventory with fallback names. |
templates/consumer-repo/scripts/sync_test_dependencies.py |
Mirrors the repo sync dependency script changes for consumers. |
tests/scripts/test_sync_test_dependencies.py |
Expands missing-dependency regression coverage for stdlib imports and jwt. |
tests/scripts/test_sync_test_dependencies_mapping.py |
Updates mapping tests for jwt and stdlib module presence. |
.github/scripts/__tests__/keepalive-orchestrator-gate-runner.test.js |
Hardens ready-for-review mutation brace validation. |
|
|
||
| assert module.MODULE_TO_PACKAGE["pptx"] == "python-pptx" | ||
| assert module.MODULE_TO_PACKAGE["jwt"] == "PyJWT" | ||
| assert {"html", "http", "secrets"}.issubset(module.STDLIB_MODULES) |
Contributor
Automated Status SummaryHead SHA: 4209cf6
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
This was referenced May 14, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Supersedes #1994 for the stdlib dependency fix and addresses the remaining actionable #1985 mutation-test review comment.