fix(users-permissions): fix role notification translations#26933
Merged
innerdvations merged 3 commits intoJul 21, 2026
Merged
Conversation
|
|
dosubot
Bot
added
pr: fix
github-actions
Bot
added
the
community
Contributor
|
This PR has been added to our community triage board as CPR-436. |
innerdvations
requested changes
Jul 8, 2026
innerdvations
left a comment
innerdvations
left a comment
Contributor
There was a problem hiding this comment.
I think this one should remain as 'created'
Contributor
|
Size Change: +12.2 kB (+0.37%) Total Size: 3.35 MB 📦 View Changed
ℹ️ View Unchanged
|
9 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe role edit success notification in EditPage.jsx now references the "edited" translation id instead of "created". A new translation entry, "Settings.roles.created", is added to en.json for the role creation notification. ChangesRole notification translation fix
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
innerdvations
approved these changes
Jul 17, 2026
Contributor
|
Thanks for the update — the translation fix looks good and CI is green. One last step before we can merge: could you please sign the Contributor License Agreement? Once that’s done, we should be clear to merge. AI-assisted comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes incorrect translation keys used in users-permissions role notifications.
Changes made:
Settings.roles.createdtranslation key inen.json.EditPage.jsxto useSettings.roles.editedinstead ofSettings.roles.created.Why is it needed?
In Strapi v5, the edit role notification was using the wrong translation key (
Settings.roles.created), and the created role notification key was missing from the translation catalog.Because of this, localised messages were not displayed, and the default English message was always shown.
How to test it?
Environment:
Steps:
yarn build.Related issue(s)/PR(s)
Fixes #26917
Fixes CPR-436