Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Dec 1, 2025

Related stratis-storage/project#814

Summary by CodeRabbit

  • Chores

    • Removed shell completion support for Bash, Fish, and Zsh shells, including all completion scripts and dynamic completion logic.
    • Removed shell formatting validation checks from CI workflow and build configuration.
  • Documentation

    • Removed the tab completion documentation section.

✏️ Tip: You can customize this high-level summary in your review settings.

@mulkieran mulkieran self-assigned this Dec 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

Removes shell completion scripts for bash, fish, and zsh, and deletes related shell-format targets from the Makefile and the shfmt step from the GitHub Actions python-checks matrix.

Changes

Cohort / File(s) Summary
Shell completion scripts
shell-completion/bash/stratis, shell-completion/fish/stratis.fish, shell-completion/zsh/_stratis
Deleted entire completion scripts for bash, fish, and zsh, removing all completion functions, helper utilities, dynamic completion calls, and registration wiring.
CI workflow updates
.github/workflows/main.yml
Removed shfmt dependency and the make -f Makefile fmt-shell-ci task from the python-checks matrix entry, skipping shell-format validation in that matrix job.
Build system cleanup
Makefile
Removed fmt-shell and fmt-shell-ci targets that previously invoked shfmt on the shell-completion files.
Documentation
README.rst
Removed the Tab Completion section in the Python Coding Style portion of the README; tab-completion documentation deleted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify no other build or install targets reference the deleted completion scripts.
  • Confirm no downstream packaging or install manifests expect those completion files.
  • Check CI matrix entries or workflow steps for lingering references to shfmt or the removed Makefile targets.

Poem

I nibble lines of bash, fish, zsh with cheer,
Then gently tuck their completions out of here.
CI trims a step, Makefile sheds a leaf,
A rabbit hops on—light, nimble, and brief. 🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove tab completion files' accurately and concisely summarizes the main change: the deletion of all shell completion files (bash, fish, zsh), their associated Makefile targets, workflow steps, and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae76e96 and f6bd99d.

📒 Files selected for processing (6)
  • .github/workflows/main.yml (0 hunks)
  • Makefile (0 hunks)
  • README.rst (0 hunks)
  • shell-completion/bash/stratis (0 hunks)
  • shell-completion/fish/stratis.fish (0 hunks)
  • shell-completion/zsh/_stratis (0 hunks)
💤 Files with no reviewable changes (6)
  • shell-completion/bash/stratis
  • shell-completion/fish/stratis.fish
  • .github/workflows/main.yml
  • Makefile
  • shell-completion/zsh/_stratis
  • README.rst
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test-runs (3.13)
  • GitHub Check: test-runs (3.12)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran moved this to In Review in 2025November Dec 1, 2025
@mulkieran mulkieran force-pushed the issue_stratis-cli_814 branch from ae76e96 to f6bd99d Compare December 1, 2025 02:54
For a while I did a best effort maintenance activity, but the last time
I did that was in 2022. If we decide to support tab completion, we will
use an automatic generation facility.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran merged commit e35f5c9 into stratis-storage:master Dec 1, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025November Dec 1, 2025
@mulkieran mulkieran deleted the issue_stratis-cli_814 branch December 1, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant