fix deadlock on fast init deinit of filters#718
Merged
summeroff merged 2 commits intostreamlabsfrom Apr 2, 2026
Merged
Conversation
sandboxcoder
approved these changes
Apr 2, 2026
mhoyer-streamlabs
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
nvidia_audio_destroy locks ng->nvafx_mutex and then calls pthread_join on the init thread. The init thread (nvidia_audio_initialize) also needs to acquire ng->nvafx_mutex as its first step. When deferred destruction
runs before the init thread has acquired the mutex, this creates a deadlock:
This cascades to nvidia_afx_initializer_mutex (the global mutex shared across all NVIDIA audio filter instances), blocking initialization of any subsequent NVIDIA audio filters and stalling obs_wait_for_destroy_queue.
Fix
Move pthread_join before the mutex lock in nvidia_audio_destroy. The init thread runs to completion first (releasing all locks), then destroy safely locks the mutex for cleanup.
Types of changes
Checklist: