Settings menu updates#12648
Merged
Merged
Conversation
mayagbarnes
added
security-assessment-completed
change:refactor
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0300%
💡 Consider adding more unit tests to maintain or improve coverage. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the theme creator dialog functionality and implements a settings menu fix to prevent reverting to default Streamlit themes when a custom theme is active.
- Removes the
ThemeCreatorDialogcomponent and all related functionality - Fixes
SettingsDialogbug where users could revert to default themes when a custom theme was set by disabling the selectbox when custom themes are present - Improves cursor styling consistency for disabled selectboxes by applying
not-allowedcursor to dropdown arrows
Reviewed Changes
Copilot reviewed 15 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
frontend/lib/src/theme/themeConfigs.ts |
Adds new customTheme export for testing purposes |
frontend/lib/src/test_util.tsx |
Removes addThemes from test context mocks |
frontend/lib/src/index.ts |
Exports the new customTheme configuration |
frontend/lib/src/components/shared/Dropdown/Selectbox.tsx |
Adds conditional not-allowed cursor styling for disabled dropdown arrows |
frontend/lib/src/components/core/LibContext.tsx |
Removes addThemes function from LibContext interface |
frontend/app/src/components/StreamlitDialog/styled-components.ts |
Removes unused StyledBackButton component |
frontend/app/src/components/StreamlitDialog/ThemeCreatorDialog.tsx |
Completely removes the theme creator dialog component |
frontend/app/src/components/StreamlitDialog/ThemeCreatorDialog.test.tsx |
Removes all tests for the deleted theme creator dialog |
frontend/app/src/components/StreamlitDialog/StreamlitDialog.tsx |
Removes theme creator dialog from main dialog router |
frontend/app/src/components/StreamlitDialog/SettingsDialog.tsx |
Implements logic to disable theme selection when custom themes are active |
frontend/app/src/components/StreamlitDialog/SettingsDialog.test.tsx |
Updates tests to cover new custom theme behavior |
frontend/app/src/components/StreamlitContextProvider.tsx |
Removes addThemes from context provider |
frontend/app/src/App.tsx |
Removes theme creator dialog opening functionality |
e2e_playwright/theming/custom_theme_fonts_test.py |
Adds E2E test for custom theme settings dialog behavior |
e2e_playwright/main_menu_test.py |
Removes E2E test for theme creator dialog |
sfc-gh-bnisco
approved these changes
Sep 29, 2025
Collaborator
sfc-gh-bnisco
left a comment
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Always great when we get to delete code 👍
sfc-gh-tteixeira
pushed a commit
that referenced
this pull request
Sep 30, 2025
Some changes to set the stage for allowing custom light & dark themes: * Fix `SettingsCreatorDialog` bug where you could revert to streamlit default themes (auto/light/dark) when a custom theme was set * Remove the `ThemeCreatorDialog` * Small update to cursor styling for selectboxes (the main input had not-allowed cursor but the dropdown arrow didn't)
lukasmasuch
added a commit
that referenced
this pull request
Feb 5, 2026
The theme creator dialog UI was removed in PR #12648 but themeUtils.ts and its associated exports (themeBuilder, toMinimalToml) were left as dead code. Remove these unused files and the orphaned THEME_CREATOR enum value.
lukasmasuch
added a commit
that referenced
this pull request
Feb 9, 2026
The theme creator dialog UI was removed in PR #12648 but themeUtils.ts and its associated exports (themeBuilder, toMinimalToml) were left as dead code. Remove these unused files and the orphaned THEME_CREATOR enum value.
lukasmasuch
added a commit
that referenced
this pull request
Feb 9, 2026
## Describe your changes Clean up deprecated and unused code from the theme system: 1. **Remove deprecated proto fields** from `CustomThemeConfig`: - `font` (replaced by `body_font`) - `widget_background_color` (no longer applied) - `widget_border_color` (replaced by `border_color` + `show_widget_border`) - `radii` (replaced by `base_radius`) - `font_sizes` (replaced by `base_font_size`) - `skeleton_background_color` (no longer applied) - `FontFace.weight` (replaced by `weight_range`) 2. **Remove unused theme creator code**: - Delete `themeUtils.ts` and `themeUtils.test.ts` (dead code since #12648) - Remove orphaned `THEME_CREATOR` enum value from `DialogType` Reserved field numbers are added to maintain proto compatibility. - Closes: #13831 ## Testing Plan - No new tests needed; this removes dead/deprecated code - Updated existing tests to remove references to deprecated fields - Frontend and backend changes are compatible with existing functionality --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Streamlit Bot <core+streamlitbot-github@streamlit.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some changes to set the stage for allowing custom light & dark themes:
SettingsCreatorDialogbug where you could revert to streamlit default themes (auto/light/dark) when a custom theme was setThemeCreatorDialogTesting Plan