Remove deprecated proto fields and unused theme creator code#13842
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
lukasmasuch
changed the title
lukasmasuch
added
impact:internal
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead code that was left behind after the theme creator dialog UI was removed in PR #12648. The cleanup includes the utility functions for theme configuration and TOML generation that are no longer needed.
Changes:
- Removed
themeUtils.tscontaining theme builder configuration and TOML generation utilities - Removed
themeUtils.test.tscontaining tests for the deleted utilities - Removed
THEME_CREATORenum value fromDialogTypeenum
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/app/src/components/StreamlitDialog/themeUtils.ts | Deleted theme utility functions including themeBuilder configuration and toMinimalToml TOML generator |
| frontend/app/src/components/StreamlitDialog/themeUtils.test.ts | Deleted corresponding unit tests for the removed theme utilities |
| frontend/app/src/components/StreamlitDialog/constants.ts | Removed orphaned THEME_CREATOR enum value that was no longer used after dialog removal |
lukasmasuch
pushed a commit
that referenced
this pull request
Feb 6, 2026
## Describe your changes Automated snapshot updates for #13842 created via the snapshot autofix CI workflow. This workflow was triggered by adding the `update-snapshots` label to a PR after Playwright E2E tests failed with snapshot mismatches. **Updated snapshots:** 3 file(s)⚠️ **Please review the snapshot changes carefully** - they could mask visual bugs if accepted blindly. This PR targets a feature branch and can be merged without review approval. Co-authored-by: Streamlit Bot <core+streamlitbot-github@streamlit.io>
The theme creator dialog UI was removed in PR #12648 but themeUtils.ts and its associated exports (themeBuilder, toMinimalToml) were left as dead code. Remove these unused files and the orphaned THEME_CREATOR enum value.
Remove deprecated and unused proto fields: font, widget_background_color, widget_border_color, radii, font_sizes, skeleton_background_color, and FontFace.weight. Add reserved field numbers to maintain proto compatibility. Update frontend theme utils and tests to remove references to these fields.
Remove references to deleted proto messages (Radii, FontSizes) and fields (font, widget_background_color, widget_border_color, etc.) from the compatibility test suite.
Automated snapshot updates for #13842 created via the snapshot autofix CI workflow. This workflow was triggered by adding the `update-snapshots` label to a PR after Playwright E2E tests failed with snapshot mismatches. **Updated snapshots:** 3 file(s)⚠️ **Please review the snapshot changes carefully** - they could mask visual bugs if accepted blindly. This PR targets a feature branch and can be merged without review approval. Co-authored-by: Streamlit Bot <core+streamlitbot-github@streamlit.io>
lukasmasuch
force-pushed
the
lukasmasuch/remove-deprecated-proto
branch
from
35dbd4f to
8531cf0
Compare
mayagbarnes
approved these changes
Feb 9, 2026
Update chromium and firefox snapshots after theme-related changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Clean up deprecated and unused code from the theme system:
Remove deprecated proto fields from
CustomThemeConfig:font(replaced bybody_font)widget_background_color(no longer applied)widget_border_color(replaced byborder_color+show_widget_border)radii(replaced bybase_radius)font_sizes(replaced bybase_font_size)skeleton_background_color(no longer applied)FontFace.weight(replaced byweight_range)Remove unused theme creator code:
themeUtils.tsandthemeUtils.test.ts(dead code since Settings menu updates #12648)THEME_CREATORenum value fromDialogTypeReserved field numbers are added to maintain proto compatibility.
widgetBackgroundColor,widgetBorderColor,skeletonBackgroundColor) #13831Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.