chore(backend/sdoc_source_code): MarkerParser class: require explicit arguments for better readability #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislaw
changed the title
stanislaw
force-pushed
the
stanislaw/explicit_args
branch
from
ccd7aa3 to
54fcc6c
Compare
… arguments for better readability The upcoming PR #2555 adds some more variables to this class, and it feels like it is time to enforce the explicit argument names every time this class's constructor is called. This should help with avoiding the issues when a wrong position argument can be set in place of the right one.
stanislaw
force-pushed
the
stanislaw/explicit_args
branch
from
54fcc6c to
922a3a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming PR #2555 adds some more variables to this class, and it feels like it is time to enforce the explicit argument names every time this class's constructor is called. This should help with avoiding the issues when a wrong position argument can be set in place of the right one.