Fix: Replace AskUserQuestion with question tool in skill files#9
Conversation
|
fatal: could not read Username for 'https://github.com': No such device or address |
Changed permissions for contents from read to write and updated checkout action to persist credentials.
Changed persist-credentials to true and added GITHUB_TOKEN.
|
Here's my review of PR "Fix: Replace AskUserQuestion with question tool in skill files": SummaryThis is a mechanical find-and-replace refactor across 39 skill files (197 additions, 197 deletions). Every occurrence of Changes By Category
QualityNo bugs found. The change is consistent and complete — every Minor Observations
VerdictApproved. Clean refactor, consistent application, zero regressions beyond the minor phrasing concern noted above. |
Bug fixes: - #1: division-by-zero guard in coverage calculation - #2: actions versions @v6 -> @v4 - #3: remove redundant git query in changelog-generator session.idle - #4: YAML frontmatter parser handles multi-line values - #8: Windows line endings in frontmatter parser (split with /\r?\n/) Quality: - #5: deduplicate Collaboration Protocol in 4 agents (~200 lines -> ~40) - #6: changelog-generator no longer re-queries git in event handler - #7: GDScript validator --strict flag for non-zero exit - #9: simpler subagent_type regex in cross-reference validator - #11: error sections counted as Failed in report totals

Closes #4