Skip to content

Fix: Replace AskUserQuestion with question tool in skill files#9

Merged
striderZA merged 4 commits into
developmentfrom
fix/askuserquestion
May 1, 2026
Merged

Fix: Replace AskUserQuestion with question tool in skill files#9
striderZA merged 4 commits into
developmentfrom
fix/askuserquestion

Conversation

@striderZA

Copy link
Copy Markdown
Owner

Closes #4

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

fatal: could not read Username for 'https://github.com': No such device or address

opencode session  |  github run

striderZA added 3 commits May 1, 2026 21:38
Changed permissions for contents from read to write and updated checkout action to persist credentials.
Changed persist-credentials to true and added GITHUB_TOKEN.
@striderZA striderZA merged commit 8c36b35 into development May 1, 2026
1 check passed
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Here's my review of PR "Fix: Replace AskUserQuestion with question tool in skill files":

Summary

This is a mechanical find-and-replace refactor across 39 skill files (197 additions, 197 deletions). Every occurrence of AskUserQuestion is replaced with question.

Changes By Category

Change Type Files Affected
allowed-tools frontmatter (tool whitelist) All 39 files
Inline code references (`AskUserQuestion`) ~140 occurrences
Prose references ("via AskUserQuestion", "use AskUserQuestion to...") ~50 occurrences
Negative instructions ("Do not use AskUserQuestion here") 3 files

Quality

No bugs found. The change is consistent and complete — every AskUserQuestion reference was updated. The allowed-tools lists now correctly declare question instead of the old tool name.

Minor Observations

  1. Readability regression in start/SKILL.md:108:

    -Use plain text, not AskUserQuestion (it's an open response).
    +Use plain text, not question (it's an open response).
    

    "not question" is ambiguous — could be read as "not a question" rather than "not the question tool". Consider: not the question tool or not `question`.

  2. If the platform still supports AskUserQuestion as a legacy alias, consider tracking whether any downstream tools or integrations reference the old name outside these files.

Verdict

Approved. Clean refactor, consistent application, zero regressions beyond the minor phrasing concern noted above.

New%20session%20-%202026-05-01T19%3A40%3A35.924Z
opencode session  |  github run

@striderZA striderZA deleted the fix/askuserquestion branch May 2, 2026 07:05
striderZA added a commit that referenced this pull request May 4, 2026
Bug fixes:
- #1: division-by-zero guard in coverage calculation
- #2: actions versions @v6 -> @v4
- #3: remove redundant git query in changelog-generator session.idle
- #4: YAML frontmatter parser handles multi-line values
- #8: Windows line endings in frontmatter parser (split with /\r?\n/)

Quality:
- #5: deduplicate Collaboration Protocol in 4 agents (~200 lines -> ~40)
- #6: changelog-generator no longer re-queries git in event handler
- #7: GDScript validator --strict flag for non-zero exit
- #9: simpler subagent_type regex in cross-reference validator
- #11: error sections counted as Failed in report totals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant