Add a route that automatically enqueues jobs to Resque #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
reviewed
Apr 14, 2019
| put ':workflow', to: 'workflows#create' | ||
| put ':workflow/:process', to: 'workflows#update' | ||
| put ':workflow/:process', to: 'steps#update' | ||
| post ':workflow/:process/next', to: 'steps#next' |
Member
There was a problem hiding this comment.
PR is looking good so far. I'm curious about mixing post and put here. Does steps#next
function more like a create operation? The methods look similar to me.
mjgiarlo
reviewed
Apr 14, 2019
| password: 'password' | ||
|
|
||
| enable_stomp: true | ||
| enable_queuing: true |
Member
There was a problem hiding this comment.
Can you say more about what this change adds?
Contributor
Author
|
Superseded by #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use this we'll have to add a method to dor-workflow-client. Then use that client in lyber-core, and update robot master such that it doesn't enqueue for these workflows.
This is helpful because currently robot-master hammers the workflow service with expensive requests for "what stuff is ready to be enqueued?" The current process also introduces additional delays.
sdr-ingest-receivedhttps://github.com/sul-dlss/preservation_robots/blob/1d870126fa06abafa4f38a4a6ee6f961744b115d/robots/preservation_ingest/complete_ingest.rb#L44