Skip to content

chore: add golangci-lint to CI - #2784

Open
xlgmokha wants to merge 1 commit into
supabase:masterfrom
xlgmokha:xlg/golangci-lint-build
Open

chore: add golangci-lint to CI#2784
xlgmokha wants to merge 1 commit into
supabase:masterfrom
xlgmokha:xlg/golangci-lint-build

Conversation

@xlgmokha

@xlgmokha xlgmokha commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Chore. This change adds golangci-lint as a tool for running standard
linters across the codebase. It bundles govet, staticcheck, errcheck,
ineffassign, unused and gosec.

What is the current behavior?

モ make lint
./hack/check-go-version.sh
Go version 1.27.0 is consistent across all pinned files.
go vet ./...
tools/bin/staticcheck ./...
tools/bin/gosec \
		-quiet \
		-exclude-generated \
		-exclude=G117,G120,G704 \
		./...
tools/bin/gosec \
		-quiet \
		-tests \
		-exclude-generated \
		-exclude=G101,G104,G117,G120,G704 \
		./...
tools/bin/govulncheck ./... | go run ./hack/vulncheck-filter
ignoring GO-2026-5004: pgx/v4 SQL injection via dollar-quoted placeholder confusion, no fix available. Transitive via pop/v6.
ignoring GO-2026-4518: pgproto3/v2 DoS, no fix available (EOL). Transitive via pgconn v1 + pop/v6.

What is the new behavior?

モ make lint
./hack/check-go-version.sh
Go version 1.27.0 is consistent across all pinned files.
tools/bin/golangci-lint run ./...
0 issues.
tools/bin/govulncheck ./... | go run ./hack/vulncheck-filter
ignoring GO-2026-5004: pgx/v4 SQL injection via dollar-quoted placeholder confusion, no fix available. Transitive via pop/v6.
ignoring GO-2026-4518: pgproto3/v2 DoS, no fix available (EOL). Transitive via pgconn v1 + pop/v6.

Additional context

@xlgmokha xlgmokha self-assigned this Sep 3, 2026
@xlgmokha
xlgmokha force-pushed the xlg/golangci-lint-build branch from 0f2c913 to d160f09 Compare September 3, 2026 19:17
@xlgmokha
xlgmokha force-pushed the xlg/golangci-lint-build branch from 56d6ba4 to 9030d07 Compare September 3, 2026 20:44
@xlgmokha
xlgmokha marked this pull request as ready for review September 3, 2026 20:56
@xlgmokha
xlgmokha requested a review from a team as a code owner September 3, 2026 20:56

@fadymak fadymak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants