Skip to content

docs(stack): align runtime architecture documentation - #6078

Merged
jgoux merged 1 commit into
developfrom
agent/architecture-docs-baseline
Aug 5, 2026
Merged

docs(stack): align runtime architecture documentation#6078
jgoux merged 1 commit into
developfrom
agent/architecture-docs-baseline

Conversation

@jgoux

@jgoux jgoux commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace obsolete research ADRs with implementation-backed package architecture documentation.
  • Document the current process supervisor, desired-state lifecycle, compiled self-dispatch, stack service topology, detach persistence, and cleanup boundaries.
  • Preserve the runtime incident context while removing copied version defaults that drift from source.

Why

The previous documentation mixed research decisions with an earlier implementation shape. Keeping the operational contract beside the packages that own it gives the remaining architecture work an accurate, maintainable baseline.

@jgoux
jgoux added this pull request to the merge queue Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@95db7ba527aa47a5e0131651abb63197e64b4bb2

Preview package for commit 95db7ba.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95db7ba527

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/stack/docs/detach-mode.md
Comment thread docs/adr/0012-compiled-bun-runtime-dispatch.md
Comment thread packages/stack/docs/architecture.md
@jgoux
jgoux added this pull request to the merge queue Aug 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 5, 2026
@jgoux
jgoux added this pull request to the merge queue Aug 5, 2026
Merged via the queue into develop with commit 0cf61b3 Aug 5, 2026
37 checks passed
@jgoux
jgoux deleted the agent/architecture-docs-baseline branch August 5, 2026 16:02
pull Bot pushed a commit to oogalieboogalie/cli that referenced this pull request Aug 6, 2026
## Summary

Health-check failures before first readiness were not reported, and
exhausted unhealthy restart budgets left services non-terminal with
stale process metadata. Hook failures could also publish `Failed` while
their child remained active.

This change centralizes restart decisions, separates startup and
liveness thresholds, and makes supervisory health termination explicit.
Terminal states clear the PID, health exhaustion retains no fabricated
exit code, and hook failures finalize their child before state
publication.

Stack services now use explicit cold-start budgets. State contracts are
covered through raw orchestration, stack projection, daemon transport,
and dashboard fixtures, with cold-start coverage for PostgreSQL, Edge
Runtime, and Analytics.

This PR is stacked on supabase#6078, which provides the architecture
documentation baseline.
pull Bot pushed a commit to oogalieboogalie/cli that referenced this pull request Aug 6, 2026
## Summary

- establish an exhaustive static service catalog for identity, versions,
artifacts, activation policy, and port ownership
- move public and resolved configuration types into a focused module and
isolate configuration resolution from the Promise facade
- define explicit finite, infinite, and inherited readiness policies
with deterministic precedence
- route artifact preparation through one canonical resolution path while
keeping cross-service topology explicit in the stack builder
- update package documentation and version-sync tooling for the new
ownership boundaries

This change is stacked on supabase#6078 and should be reviewed after it.
pull Bot pushed a commit to oogalieboogalie/cli that referenced this pull request Aug 6, 2026
## Summary

- Generalize detached orphan cleanup to validated, shell-free command
and path actions.
- Make lifecycle transition classification event-exhaustive and move
ordered restart closure traversal into a pure module.
- Remove confirmed dead error and log-buffer surface while documenting
the supervisor entry and one-shot polling contracts.

## Why

The process supervisor should remain domain-neutral and keep policy
decisions independently testable without changing the lifecycle
semantics established by the preceding work.

Depends on supabase#6080 and transitively on supabase#6078.
pull Bot pushed a commit to oogalieboogalie/cli that referenced this pull request Aug 6, 2026
## What changed

- replaces the duplicate lifecycle coordinator tag and pass-through
facade with one scoped local stack implementation that provides both the
public stack and narrow activation interfaces
- centralizes readiness policy enforcement across startup, activation,
lifecycle operations, explicit waits, Promise calls, and daemon
transport
- adds typed readiness deadline failures with terminal scoped cleanup
and daemon shutdown
- validates readiness overrides over POST transport and documents the
shared foreground/detached behavior
- removes dead cleanup-query surface and uses structural Effect equality
for projected state deduplication

## Why

Lifecycle state previously had redundant interface layers and readiness
deadlines were enforced only by the Promise adapter. Keeping policy and
cleanup inside the single runtime owner makes every adapter observe the
same semantics and prevents a timed-out runtime from relaunching
resources after cleanup.

Depends on supabase#6081 and supabase#6080 (and transitively supabase#6078).
pull Bot pushed a commit to chizee/cli that referenced this pull request Aug 7, 2026
## What changed

- makes StackBuilder the sole owner of dependency topology and passes
explicit dependencies into every service factory, including the
native-initialization versus Docker-readiness choice for PostgREST
- moves Docker network and port argument construction into service
factories and migrates PostgreSQL, Auth, and PostgREST onto the common
Docker definition helper
- centralizes container identity so launch, exact cleanup, orphan
cleanup, and catalog-derived candidate cleanup use the same naming
source
- captures exact build-produced cleanup targets before persistence and
orchestrator setup, and disposes already-started resources after any
partial startup failure
- expands semantic service-definition coverage and documents the
exact-versus-candidate cleanup model

## Why

Service construction and resource identity were split across the
builder, individual factories, and fallback cleanup code. Keeping
topology in the builder while concentrating executable details and
Docker identity in factories makes service definitions easier to change
safely, prevents launch and cleanup names from drifting, and ensures
failed startup cannot leave an earlier service running.

Depends on supabase#6085 and supabase#6084 (and transitively supabase#6081, supabase#6080, and supabase#6078).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants