docs(stack): align runtime architecture documentation - #6078
Merged
Conversation
This was referenced Aug 5, 2026
jgoux
marked this pull request as ready for review
August 5, 2026 13:41
jgoux
enabled auto-merge
August 5, 2026 13:42
Coly010
approved these changes
Aug 5, 2026
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@95db7ba527aa47a5e0131651abb63197e64b4bb2Preview package for commit |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 5, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95db7ba527
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 5, 2026
pull Bot
pushed a commit
to oogalieboogalie/cli
that referenced
this pull request
Aug 6, 2026
## Summary Health-check failures before first readiness were not reported, and exhausted unhealthy restart budgets left services non-terminal with stale process metadata. Hook failures could also publish `Failed` while their child remained active. This change centralizes restart decisions, separates startup and liveness thresholds, and makes supervisory health termination explicit. Terminal states clear the PID, health exhaustion retains no fabricated exit code, and hook failures finalize their child before state publication. Stack services now use explicit cold-start budgets. State contracts are covered through raw orchestration, stack projection, daemon transport, and dashboard fixtures, with cold-start coverage for PostgreSQL, Edge Runtime, and Analytics. This PR is stacked on supabase#6078, which provides the architecture documentation baseline.
pull Bot
pushed a commit
to oogalieboogalie/cli
that referenced
this pull request
Aug 6, 2026
## Summary - establish an exhaustive static service catalog for identity, versions, artifacts, activation policy, and port ownership - move public and resolved configuration types into a focused module and isolate configuration resolution from the Promise facade - define explicit finite, infinite, and inherited readiness policies with deterministic precedence - route artifact preparation through one canonical resolution path while keeping cross-service topology explicit in the stack builder - update package documentation and version-sync tooling for the new ownership boundaries This change is stacked on supabase#6078 and should be reviewed after it.
pull Bot
pushed a commit
to oogalieboogalie/cli
that referenced
this pull request
Aug 6, 2026
## Summary - Generalize detached orphan cleanup to validated, shell-free command and path actions. - Make lifecycle transition classification event-exhaustive and move ordered restart closure traversal into a pure module. - Remove confirmed dead error and log-buffer surface while documenting the supervisor entry and one-shot polling contracts. ## Why The process supervisor should remain domain-neutral and keep policy decisions independently testable without changing the lifecycle semantics established by the preceding work. Depends on supabase#6080 and transitively on supabase#6078.
pull Bot
pushed a commit
to oogalieboogalie/cli
that referenced
this pull request
Aug 6, 2026
## What changed - replaces the duplicate lifecycle coordinator tag and pass-through facade with one scoped local stack implementation that provides both the public stack and narrow activation interfaces - centralizes readiness policy enforcement across startup, activation, lifecycle operations, explicit waits, Promise calls, and daemon transport - adds typed readiness deadline failures with terminal scoped cleanup and daemon shutdown - validates readiness overrides over POST transport and documents the shared foreground/detached behavior - removes dead cleanup-query surface and uses structural Effect equality for projected state deduplication ## Why Lifecycle state previously had redundant interface layers and readiness deadlines were enforced only by the Promise adapter. Keeping policy and cleanup inside the single runtime owner makes every adapter observe the same semantics and prevents a timed-out runtime from relaunching resources after cleanup. Depends on supabase#6081 and supabase#6080 (and transitively supabase#6078).
pull Bot
pushed a commit
to chizee/cli
that referenced
this pull request
Aug 7, 2026
## What changed - makes StackBuilder the sole owner of dependency topology and passes explicit dependencies into every service factory, including the native-initialization versus Docker-readiness choice for PostgREST - moves Docker network and port argument construction into service factories and migrates PostgreSQL, Auth, and PostgREST onto the common Docker definition helper - centralizes container identity so launch, exact cleanup, orphan cleanup, and catalog-derived candidate cleanup use the same naming source - captures exact build-produced cleanup targets before persistence and orchestrator setup, and disposes already-started resources after any partial startup failure - expands semantic service-definition coverage and documents the exact-versus-candidate cleanup model ## Why Service construction and resource identity were split across the builder, individual factories, and fallback cleanup code. Keeping topology in the builder while concentrating executable details and Docker identity in factories makes service definitions easier to change safely, prevents launch and cleanup names from drifting, and ensures failed startup cannot leave an earlier service running. Depends on supabase#6085 and supabase#6084 (and transitively supabase#6081, supabase#6080, and supabase#6078).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous documentation mixed research decisions with an earlier implementation shape. Keeping the operational contract beside the packages that own it gives the remaining architecture work an accurate, maintainable baseline.