Skip to content

fix: accept 201 from API #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soedirgo merged 1 commit into from
Aug 10, 2022
Merged

fix: accept 201 from API #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/functions/deploy/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ Enter your project ref: `, utils.GetSupabaseDashboardURL())
defer resp.Body.Close()

body, err := io.ReadAll(resp.Body)
if resp.StatusCode != http.StatusOK {
// TODO: remove the StatusOK case after 2022-08-20
if resp.StatusCode != http.StatusCreated && resp.StatusCode != http.StatusOK {
if err != nil {
return fmt.Errorf("Failed to create a new Function on the Supabase project: %w", err)
}
Expand Down
1 change: 1 addition & 0 deletions internal/projects/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func Run(params RequestParam, fsys afero.Fs) error {
}
defer resp.Body.Close()

// TODO: remove the StatusOK case after 2022-08-20
if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
body, err := io.ReadAll(resp.Body)
if err != nil {
Expand Down