fix(storage): local storage presigned urls #4332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests
Bisected to the right commit with this script:
https://github.com/supabase/cli/blob/85a4bf736bb69a1936dcec70e1572ef8b7c0cdb3/test.ts
And running:
To check when the bug was introduced. Found the culprit here: ac5c902
We now bypass the kong transformation when the url is an url of the S3 protocol.
Improvements:
Might wanna setup some e2e tests on this so we don't experience regression like this in the future.