Skip to content

Conversation

avallete
Copy link
Member

@avallete avallete commented Oct 20, 2025

What kind of change does this PR introduce?

  • The kong transform shoudn't be applied over S3 storage endpoint so the right token can be passed along.

Tests

Bisected to the right commit with this script:

https://github.com/supabase/cli/blob/85a4bf736bb69a1936dcec70e1572ef8b7c0cdb3/test.ts

And running:

go run . stop --all --no-backup && go run . start && deno run --allow-env --allow-net --allow-read --allow-sys test.ts

To check when the bug was introduced. Found the culprit here: ac5c902

We now bypass the kong transformation when the url is an url of the S3 protocol.

Improvements:

Might wanna setup some e2e tests on this so we don't experience regression like this in the future.

@avallete avallete requested a review from a team as a code owner October 20, 2025 18:47
@avallete avallete requested a review from sweatybridge October 20, 2025 18:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18661732577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 54.579%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 18649941002: -0.03%
Covered Lines: 6389
Relevant Lines: 11706

💛 - Coveralls

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@sweatybridge sweatybridge merged commit ec88366 into develop Oct 20, 2025
14 checks passed
@sweatybridge sweatybridge deleted the fix/local-storage-presigned-urls branch October 20, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants