Skip to content

fix(storage): local storage presigned urls #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

fix(storage): local storage presigned urls #4332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85a4bf7
chore: setup local test for bisect
avallete Oct 20, 2025
9580903
fix(storage): kong transformation for storage s3 endpoints
avallete Oct 20, 2025
084d897
Revert "chore: setup local test for bisect"
avallete Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion internal/start/templates/kong.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,23 @@ services:
replace:
headers:
- "Authorization: {{ .BearerToken }}"
# S3-compatible storage endpoint (no Authorization header transformation)
- name: storage-v1-s3
_comment: "Storage S3: /storage/v1/s3/* -> http://storage-api:5000/s3/*"
url: http://{{ .StorageId }}:5000/s3
routes:
- name: storage-v1-s3-all
strip_path: true
paths:
- /storage/v1/s3/
plugins:
- name: cors
# Note: No request-transformer plugin for Authorization header
# S3 presigned URLs require the original AWS signature in the Authorization header
# Adding/replacing with Bearer token would break S3 signature validation
# Regular storage API endpoint (with Authorization header transformation)
- name: storage-v1
_comment: "Storage: /storage/v1/* -> http://storage-api:5000/*"
_comment: "Storage API: /storage/v1/* -> http://storage-api:5000/*"
url: http://{{ .StorageId }}:5000/
routes:
- name: storage-v1-all
Expand Down