Skip to content

Conversation

@encima
Copy link
Member

@encima encima commented Nov 14, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Curren behaviour was using a general check fir _timeout to convert to string. With the addition of checkpoint_timeout, this was causing failures.

What is the new behavior?

Made timeout check explicit for statment_timeout and wal_sender_timeout so type failures do not occur

Additional context

Add any other context or screenshots.

@encima encima requested a review from a team as a code owner November 14, 2025 17:18
@coveralls
Copy link

coveralls commented Nov 14, 2025

Pull Request Test Coverage Report for Build 19372411361

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 55.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/postgresConfig/update/update.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 19354265713: -0.03%
Covered Lines: 6507
Relevant Lines: 11820

💛 - Coveralls

@encima encima force-pushed the hotfix/pgconfig-update-timeouts branch from fb1c295 to 588b7ef Compare November 14, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants