Skip to content

fix: variable check for _timeout made explicit to exclude checkpoint timeout #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: variable check for _timeout made explicit to exclude checkpoint timeout #4449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/postgresConfig/update/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func Run(ctx context.Context, projectRef string, values []string, replaceOverrid
}
// statement_timeout and wal_sender_timeout must be typed as string
for k, v := range finalOverrides {
if _, ok := v.(string); strings.HasSuffix(k, "_timeout") && !ok {
if _, ok := v.(string); strings.HasSuffix(k, "statement_timeout") || strings.HasSuffix(k, "wal_sender_timeout") && !ok {
Copy link
Contributor

@sweatybridge sweatybridge Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the type for checkpoint_timeout on api side. This param can be specified with units ie. 5min, in which case it must be a string. https://postgresqlco.nf/doc/en/param/checkpoint_timeout/

Copy link
Member Author

@encima encima Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set the timeout to only be set in seconds as an integer to prevent syntax issues bringing the database down (i.e. 10mins, 5min)

Copy link
Contributor

@sweatybridge sweatybridge Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those malformed values are validated and rejected by api for other timeouts.

Copy link
Member Author

@encima encima Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have seen a few failing cases but will fix in the API in that case!

Copy link
Member Author

@encima encima Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have seen a few failing cases but will fix in the API in that case!

Copy link
Member Author

@encima encima Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have seen a few failing cases but will fix in the API in that case!

finalOverrides[k] = fmt.Sprintf("%v", v)
}
}
Expand Down
Loading