Skip to content

Conversation

@Flamki
Copy link

@Flamki Flamki commented Feb 10, 2026

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

CLI 2.75.x attempts a TLS connection even when sslmode=disable is set in --db-url, causing tls error (server refused TLS connection). The same command succeeds with --debug because TLS is disabled there.
Issue: #4839 (regression of #4288)

What is the new behavior?

When sslmode=disable is present in the connection string, the CLI explicitly disables TLS, so non‑TLS self‑hosted databases connect successfully without needing --debug.

Additional context

This aligns normal behavior with the --debug path, which already disables TLS. No user‑visible changes beyond respecting sslmode=disable.

@Flamki Flamki requested a review from a team as a code owner February 10, 2026 17:36
@Flamki
Copy link
Author

Flamki commented Feb 10, 2026

CI status note:

  • CI / Codegenfails duringgo generatewithDiskRequestBody` discriminator mapping (pre-existing issue).
  • CI / Linkfails due to missingproject-ref` flag in CI.

All build/lint/test checks for this change are green.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21875711915

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 60.55%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 21859441939: -0.02%
Covered Lines: 7751
Relevant Lines: 12801

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants