Skip to content

fix(ci): api-sync code generate discriminated union#4863

Merged
avallete merged 1 commit intodevelopfrom
fix/api-sync-code-generate
Feb 16, 2026
Merged

fix(ci): api-sync code generate discriminated union#4863
avallete merged 1 commit intodevelopfrom
fix/api-sync-code-generate

Conversation

@avallete
Copy link
Member

@avallete avallete commented Feb 16, 2026

What kind of change does this PR introduce?

Fix the auto api-sync action codegen.

Summary by CodeRabbit

Release Notes

  • New Features
    • Manage and modify database disk configurations for your projects
    • Configure automatic disk autoscaling based on usage patterns and growth thresholds
    • Monitor disk utilization metrics to track and analyze resource consumption
    • Manage Just-In-Time access controls for enhanced security and access governance
    • Shutdown realtime connections on demand for improved operational management

@avallete avallete requested a review from a team as a code owner February 16, 2026 11:04
@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Extends the API client with new endpoints for database disk modifications, disk autoscaling configuration, disk utilization metrics, JIT access management, and realtime shutdown. Adds corresponding request builders, response types, and type definitions. Updates API overlay to remove discriminated union discriminators.

Changes

Cohort / File(s) Summary
API Overlay Configuration
api/overlay.yaml
Adds removal rule for DiskRequestBody.attributes.discriminator to replace discriminated union with concrete type, expanding scope of discriminator removals.
Generated Client Methods
pkg/api/client.gen.go
Adds 8 new API endpoint methods (V1ModifyDatabaseDisk, V1GetProjectDiskAutoscaleConfig, V1GetDiskUtilization, V1ShutdownRealtime, V1GetJitAccessConfig, V1UpdateJitAccessConfig) with request builders, response handlers, and ClientWithResponses variants. Includes new response types and corresponding parsers for each endpoint.
Generated Type Definitions
pkg/api/types.gen.go
Introduces new data types: DiskRequestBody, DiskAutoscaleConfig, DiskUtilMetricsResponse, JitAccessRequestRequest. Adds type-safe enums for DiskRequestBodyAttributes0Type, DiskRequestBodyAttributes1Type, and JitAccessRequestRequestState. Updates RegionsInfo structures with new specific-code type aliases (RegionsInfoAllSpecificCode, RegionsInfoRecommendationsSpecificCode). Adds JSON marshaling helpers for discriminated union handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(ci): api-sync code generate discriminated union' accurately summarizes the main change - fixing the auto api-sync action code generation for discriminated unions, which is reflected in the overlay.yaml modification and the extensive client/type generation changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/api-sync-code-generate

Comment @coderabbitai help to get the list of available commands and usage tips.

@avallete avallete enabled auto-merge (squash) February 16, 2026 11:39
@avallete avallete merged commit f1ebd29 into develop Feb 16, 2026
12 checks passed
@avallete avallete deleted the fix/api-sync-code-generate branch February 16, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants