Skip to content

chore: remove unmocked keyring test#4911

Open
tobert wants to merge 1 commit intosupabase:developfrom
tobert:fix/remove-broken-keyring-test
Open

chore: remove unmocked keyring test#4911
tobert wants to merge 1 commit intosupabase:developfrom
tobert:fix/remove-broken-keyring-test

Conversation

@tobert
Copy link

@tobert tobert commented Feb 28, 2026

Summary

  • Remove internal/utils/credentials/keyring_test.go which calls
    zalando/go-keyring directly against the system D-Bus secret service
  • TestDeleteAll fails on headless Linux/CI with "The name is not activatable"
    because no org.freedesktop.secrets provider is running
  • The identical coverage (Get, Set, Delete, DeleteAll + error paths) already
    exists in store_test.go using keyring.MockInit(), per CONTRIBUTING.md's
    guidance to mock external systems

Test plan

  • go test ./internal/utils/credentials/... -race -v -count=1 -failfast passes
  • No coverage lost — store_test.go covers all KeyringStore methods with mocks

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tobert tobert requested a review from a team as a code owner February 28, 2026 12:36
@coderabbitai
Copy link

coderabbitai bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 635a283 and d01404a.

📒 Files selected for processing (1)
  • internal/utils/credentials/keyring_test.go
💤 Files with no reviewable changes (1)
  • internal/utils/credentials/keyring_test.go

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed internal test file to streamline codebase maintenance.

Walkthrough

A unit test file was removed from the codebase. The deleted file internal/utils/credentials/keyring_test.go contained a test case for the go-keyring integration that verified the behavior of the DeleteAll function. The test validated that items could be added and subsequently removed from the keyring without errors, and confirmed that deleted items were no longer retrievable. No public or exported function signatures were affected by this removal.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tobert
Copy link
Author

tobert commented Feb 28, 2026

Another option would be to tag it as an integration test that so it doesn't run in the default go test ./....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant