Skip to content

fix(db): split advisors session setup from lint query#4967

Merged
avallete merged 1 commit intosupabase:developfrom
jsj:jsj/db-advisors-fix-pr
Mar 18, 2026
Merged

fix(db): split advisors session setup from lint query#4967
avallete merged 1 commit intosupabase:developfrom
jsj:jsj/db-advisors-fix-pr

Conversation

@jsj
Copy link
Contributor

@jsj jsj commented Mar 17, 2026

Fixes #4965.

Summary

  • split the local advisors session setup from the embedded lint query
  • execute set local search_path = '' separately before running the lint SQL
  • update advisors tests to cover the split query path and setup failure handling

Validation

  • go test ./internal/db/advisors
  • verified against a live local Supabase project

@jsj jsj requested a review from a team as a code owner March 17, 2026 20:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 23214527521

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 61.877%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/advisors/advisors.go 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
internal/utils/git.go 5 57.14%
Totals Coverage Status
Change from base Build 23201604318: 0.01%
Covered Lines: 8039
Relevant Lines: 12992

💛 - Coveralls

Copy link
Contributor

@Rodriguespn Rodriguespn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this @jsj

@avallete avallete merged commit bce7051 into supabase:develop Mar 18, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db advisors fails for local projects with custom ports and multi-statement lint SQL

4 participants