Merged
Conversation
Coverage Report for CI Build 24557619474Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Warning No base build found for commit Coverage: 63.662%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
avallete
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
fix docker based
functions downloadso_sharedfiles are extracted correctlyprob
when docker is used, the cli was binding only
supabase/functions/<slug>and unbundling to/home/denofor functions that import
../_shared/*those files resolve outside the bound function folder, so
_sharedis missing after downloadthe
--use-apipath works because it does not use this docker bind layoutsol
changed docker extraction to bind
supabase/functionsas the writable root and unbundle to/home/deno/<slug>IMO this keeps function files in the function folder while allowing
_sharedto be written as a sibling directoryadded a smol test as well for this
ref:
_sharedfolder not extracted with docker #5000