Skip to content

chore(cli/telemetry): clean up audited events #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pamelachia wants to merge 9 commits into
base: develop
Choose a base branch
from
+3 −9
Open

chore(cli/telemetry): clean up audited events #5234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b3820bf
fix(telemetry): drop upgrade_suggested fire on vanity check (read-onl…
pamelachia May 11, 2026
e58a55c
refactor(telemetry): align start.go stack-started capture with codeba…
pamelachia May 11, 2026
1922c18
feat(telemetry): add stitched property to cli_login_completed
pamelachia May 11, 2026
7ff221b
docs(telemetry): note early-return invariant on multi-call upgrade tr…
pamelachia May 11, 2026
fe4c653
test(telemetry): tighten alias-failure assertions on login stitching
pamelachia May 11, 2026
ad816b8
style(telemetry): tighten audit-deterrent comments
pamelachia May 11, 2026
3e88fab
chore(api): regenerate types after upstream JIT spec change
pamelachia May 11, 2026
1a15a4a
revert: drop PropStitched from cli_login_completed
pamelachia May 11, 2026
765c76c
Merge branch 'develop' into pamela/growth-797-supabasecli-clean-up-cl…
avallete May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/cli-go/internal/sso/update/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ func Run(ctx context.Context, params RunParams) error {
}

if putResp.JSON200 == nil {
// GET branch above early-returns on failure, so this and the GET fire are mutually exclusive (max one event per invocation).
if orgSlug, isGated := utils.SuggestUpgradeOnError(ctx, params.ProjectRef, "auth.saml_2", putResp.StatusCode()); isGated {
telemetry.TrackUpgradeSuggested(ctx, "auth.saml_2", orgSlug)
}
Expand Down
6 changes: 1 addition & 5 deletions apps/cli-go/internal/start/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,11 +1242,7 @@ EOF
if err := start.WaitForHealthyService(ctx, serviceTimeout, started...); err != nil {
return err
}
if service := phtelemetry.FromContext(ctx); service != nil {
if err := service.Capture(ctx, phtelemetry.EventStackStarted, nil, nil); err != nil {
fmt.Fprintln(utils.GetDebugLogger(), err)
}
}
_ = phtelemetry.FromContext(ctx).Capture(ctx, phtelemetry.EventStackStarted, nil, nil)
return nil
}

Expand Down
5 changes: 1 addition & 4 deletions apps/cli-go/internal/vanity_subdomains/check/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (

"github.com/go-errors/errors"
"github.com/spf13/afero"
"github.com/supabase/cli/internal/telemetry"
"github.com/supabase/cli/internal/utils"
"github.com/supabase/cli/pkg/api"
)
Expand All @@ -19,9 +18,7 @@ func Run(ctx context.Context, projectRef string, desiredSubdomain string, fsys a
if err != nil {
return errors.Errorf("failed to check vanity subdomain: %w", err)
} else if resp.JSON201 == nil {
if orgSlug, isGated := utils.SuggestUpgradeOnError(ctx, projectRef, "vanity_subdomain", resp.StatusCode()); isGated {
telemetry.TrackUpgradeSuggested(ctx, "vanity_subdomain", orgSlug)
}
utils.SuggestUpgradeOnError(ctx, projectRef, "vanity_subdomain", resp.StatusCode())
return errors.Errorf("unexpected check vanity subdomain status %d: %s", resp.StatusCode(), string(resp.Body))
}
if utils.OutputFormat.Value != utils.OutputPretty {
Expand Down
Loading