feat(cli): add local_smtp config#5333
Open
7ttp wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 26250005449Warning No base build found for commit Coverage: 63.767%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
adds
local_smtpas the new preferred config key, keepsinbucketvalid with a deprecation warning and updates the default template to uselocal_smtpwhat's introduced:
local_smtpis now the preferred config/schema key, while existinginbucketconfigs continue to work for now....why
basically this moves the config away from an implementation specific name without breaking existing setups in phase 1 :)
ref