test(cli): stabilize functions dev watcher test#5358
Merged
Conversation
Use a fake FileWatcher layer so the unit test no longer depends on native filesystem watcher timing. Co-authored-by: Cursor <cursoragent@cursor.com>
Make the fake FileWatcher setup match the synchronous stateful layer pattern used by nearby tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Coly010
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the
functions devruntime unit test by replacing the real filesystem watcher and temp file writes with an in-memory fakeFileWatcherlayer.The test now waits for the watch stream to register, then emits synthetic file events deterministically. This removes the CI-sensitive race around native
@parcel/watcherstartup timing.