feat(cli): migrate vanity-subdomains#5394
Merged
Merged
Conversation
- Drop `safeFlags: ["project-ref"]` from all four commands; Go's vanitySubdomains.go never calls markFlagTelemetrySafe, so project refs must be redacted in telemetry for 1:1 parity. - Wrap each API call in `output.task` so text mode shows a spinner instead of appearing to hang during network I/O. - Fix activate SIDE_EFFECTS.md API path to /vanity-subdomain/activate. - Document the `trackAnalytics` option, the `Effect.flip` error inspection, and the delete handler's legacy-output read. - Expand integration tests to 100% branch coverage across all four handlers (legacy json/yaml/toml/env, --output-format json/stream-json, absent custom_domain, network and status errors, post-run telemetry on failure) and tighten the activate endpoint assertion and gated-upgrade mock match.
Coly010
approved these changes
May 29, 2026
Contributor
Coly010
left a comment
Coly010
left a comment
There was a problem hiding this comment.
Thank you! LGTM! Just added a minor fix around marking project-ref as a safe flag. I removed it, because I don't think we want to potentially leak that data into telemetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Ports
supabase vanity-subdomains get,check-availability,activate, anddeletefrom the legacy Go proxy to native TypeScriptWhat's Introduced
This replaces the
LegacyGoProxypath for thevanity-subdomainscommand family with native handlerswired through the existing legacy management-api runtime, instrumentation, and JSON error handling path
Ref:
closes CLI-1294