fix(cli-go): avoid incompatible compose dependency#5466
Closed
jgoux wants to merge 1 commit into
Closed
Conversation
Coly010
approved these changes
Jun 4, 2026
Coverage Report for CI Build 26941969079Warning No base build found for commit Coverage: 64.05%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
avallete
requested changes
Jun 4, 2026
Comment on lines
+197
to
+211
| func pullImages(ctx context.Context, project types.Project) { | ||
| cli := &RetryClient{Client: utils.Docker} | ||
| for _, service := range project.Services { | ||
| if len(service.Image) == 0 { | ||
| continue | ||
| } | ||
| if _, err := cli.ImageInspect(ctx, service.Image); err == nil { | ||
| continue | ||
| } | ||
| out, err := cli.ImagePull(ctx, service.Image, image.PullOptions{}) | ||
| if err != nil { | ||
| continue | ||
| } | ||
| _, _ = io.Copy(io.Discard, out) | ||
| _ = out.Close() |
Member
There was a problem hiding this comment.
question
Will that still pull images in parallels like compose did ? I believe this might hit start time badly if it doesn't.
Contributor
Author
There was a problem hiding this comment.
You're right, we want to keep the dep on docker compose just for the "nice output" in parallel.
I have another PR to upgrade both docker and compose so we can keep using them.
compose-go v2.11.0 changes CreateHostPath from bool to types.OptOut, but docker/compose/v2 v2.40.3 still expects the old bool API and no newer v2 module is available. This made cli-go fail to compile during CI after the Dependabot compose-go bump. The start command only used docker/compose for best-effort image prefetching, not stack orchestration. Replace that helper with direct Docker inspect/pull calls using the existing retrying Docker client, keep missing-image pulls parallel like Compose did, de-dupe repeated image tags, and tidy the now-unused compose dependency tree.
jgoux
force-pushed
the
codex/fix-pr-5461-ci
branch
from
7f10627 to
f383466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets the Dependabot branch for #5461.
compose-go/v2@2.11.0changesCreateHostPathfrombooltotypes.OptOut, butdocker/compose/v2@2.40.3still expects the oldboolAPI and no newer v2 module is available. This caused the Go CLI build and lint jobs to fail while compiling Docker Compose internals.The start command only used Docker Compose for best-effort image prefetching before the actual Supabase container startup path. This replaces that helper with direct Docker inspect/pull calls through the existing retrying Docker client, keeps missing-image pulls parallel like Compose did, de-dupes repeated image tags, and removes the now-unused Compose dependency tree.
Added a fake-Docker regression test that verifies missing image pulls overlap concurrently.