fix(cli): remove "nano" from projects/branches create --size enum#5799
Conversation
Go's --size EnumFlag (apps/cli-go/cmd/projects.go:34-55, reused by branches create at cmd/branches.go:212) is an 18-value list that omits "nano" (and "pico") and strictly rejects any other value at flag-parse time. TS listed "nano" as a valid choice on both projects create and branches create, silently succeeding where Go errors. Fixes CLI-1869.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e1189d862
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@99ff98bea3eb456a16f8080a62e88bfa27d1b4ffPreview package for commit |
…e (review: #5799) Reorder INSTANCE_SIZES to Go's size.Allowed declaration order (apps/cli-go/cmd/projects.go:35-52, shared with branches create), matching the convention already followed by BRANCH_SIZES, NAME_ID_FORMATS, and BRANCH_STATUSES elsewhere in the legacy shell.
Coly010
deleted the
columferry/cli-1869-projects-create-branches-create-remove-nano-from-size-enum
branch
2 participants
What kind of change does this PR introduce?
Bug fix (Go parity).
What is the current behavior?
Go's
--sizeflag onprojects create(apps/cli-go/cmd/projects.go:34-55) is a single shared 18-valueEnumFlagreused bybranches create(apps/cli-go/cmd/branches.go:212), and does not include"nano"(or"pico"). The TS legacy port'sINSTANCE_SIZES(projects/create/create.command.ts) andBRANCH_SIZES(branches/create/create.command.ts) both included"nano"as a validFlag.choicevalue, so--size nanosilently succeeded in TS while Go rejects it.Verified directly against the real, compiled Go binary (
apps/cli-go) rather than just reading source —projects create --size nanogenuinely errors withinvalid argument "nano" for "--size" flag: must be one of [...], confirming this is current, shipped Go behavior and not a stale enum.Note: the live Management API contract (
packages/api/src/generated/contracts.ts) does list"nano"/"pico"as accepteddesired_instance_sizevalues, andnext/'s independently-authoredbranches createalready exposes both. Neither the Go CLI nor this legacy port surfaces them as CLI options, though — that's a separate product question (filed as CLI-1897) about whether these tiers should eventually be CLI-selectable, not a reason to keep an option the legacy shell's own Go-parity contract says should be rejected.What is the new behavior?
--size nanois now rejected identically on bothprojects createandbranches create, matching Go's 18-value enum exactly.Fixes CLI-1869. See also CLI-1897 (product decision on nano/pico) and CLI-1898 (unrelated pre-existing bug in
effect'sFlag.choiceerror-message formatting, found during this PR's review).